Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

Desktop app - Detect port and change it if needed#1395

Merged
mmv08 merged 10 commits intodevelopmentfrom
feature/detect-port
Oct 5, 2020
Merged

Desktop app - Detect port and change it if needed#1395
mmv08 merged 10 commits intodevelopmentfrom
feature/detect-port

Conversation

@matextrem
Copy link
Contributor

closes #1371

@matextrem matextrem added Enhancement ✨ Minor Improvement / changes to existing functionality Major Needs to be fixed for immediate next public release. labels Sep 24, 2020
@matextrem matextrem self-assigned this Sep 24, 2020
@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Sep 24, 2020

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 1 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Sep 24, 2020

Travis automatic deployment:
https://pr1395--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Sep 24, 2020

Travis automatic deployment:
https://pr1395--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Sep 24, 2020

Travis automatic deployment:
https://pr1395--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Sep 29, 2020

Travis automatic deployment:
https://pr1395--safereact.review.gnosisdev.com/app

@@ -98,7 +108,7 @@ function createWindow() {
mainWindow.loadURL(
isDev
? "http://localhost:3000"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there any reason to distinguish between dev and prod? If not, I would suggest to unify them. As choosing the port could be a feature handy in both environments.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The difference here is that when launching electron on development we are not using a compiled electron instance. So we are not using the internal express server instance. Instead we are running it using react-hot-loaded server (yarn start) that is used for development

@ghost
Copy link

ghost commented Oct 1, 2020

Travis automatic deployment:
https://pr1395--safereact.review.gnosisdev.com/app

1 similar comment
@ghost
Copy link

ghost commented Oct 1, 2020

Travis automatic deployment:
https://pr1395--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Oct 5, 2020

Travis automatic deployment:
https://pr1395--safereact.review.gnosisdev.com/app

@mmv08 mmv08 merged commit 21ea1ad into development Oct 5, 2020
@mmv08 mmv08 deleted the feature/detect-port branch October 5, 2020 08:52
@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Enhancement ✨ Minor Improvement / changes to existing functionality Major Needs to be fixed for immediate next public release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Desktop - Detect if port is available before starting the server

4 participants