Desktop app - Detect port and change it if needed#1395
Conversation
|
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
public/electron.js
Outdated
| @@ -98,7 +108,7 @@ function createWindow() { | |||
| mainWindow.loadURL( | |||
| isDev | |||
| ? "http://localhost:3000" | |||
There was a problem hiding this comment.
is there any reason to distinguish between dev and prod? If not, I would suggest to unify them. As choosing the port could be a feature handy in both environments.
There was a problem hiding this comment.
The difference here is that when launching electron on development we are not using a compiled electron instance. So we are not using the internal express server instance. Instead we are running it using react-hot-loaded server (yarn start) that is used for development
|
Travis automatic deployment: |
1 similar comment
|
Travis automatic deployment: |
|
Travis automatic deployment: |
closes #1371