Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

v2.12.0 Bugfix - Fix Activate/Blacklist tokens#1401

Merged
dasanra merged 3 commits intorelease/v2.12.0from
fix/activate-blacklist-tokens
Sep 25, 2020
Merged

v2.12.0 Bugfix - Fix Activate/Blacklist tokens#1401
dasanra merged 3 commits intorelease/v2.12.0from
fix/activate-blacklist-tokens

Conversation

@dasanra
Copy link
Collaborator

@dasanra dasanra commented Sep 25, 2020

This fixes #1399

Disabling tokens in the token list is not working correctly.

@dasanra dasanra self-assigned this Sep 25, 2020
@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@dasanra dasanra changed the base branch from development to release/v2.12.0 September 25, 2020 11:45
@github-actions
Copy link

github-actions bot commented Sep 25, 2020

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 6 0
Ignored 1 N/A
  • Result: ✅ success

  • Annotations: 6 total


[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods


Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Sep 25, 2020

Travis automatic deployment:
https://pr1401--safereact.review.gnosisdev.com/app

@francovenica
Copy link
Contributor

francovenica commented Sep 25, 2020

@dasanra
The enabling and disabling of tokens works fine, but there is an issue
When you load a safe that has multiple tokens it should enable all those automatically. When I load a safe like that only the ETH is enabled (since it doesn't actually have a knob in the Manage entry modal)

Try to load this safe
0x9913B9180C20C6b0F21B6480c84422F6ebc4B808

@dasanra
Copy link
Collaborator Author

dasanra commented Sep 25, 2020

@francovenica as we talked it should be loading automatically the tokens that have any amount over 0. Right now this is happening because a backend error.

Fixed the issue of saving tokens between loads, even if you don't have any balance but you manually enable it

@ghost
Copy link

ghost commented Sep 25, 2020

Travis automatic deployment:
https://pr1401--safereact.review.gnosisdev.com/app

@dasanra dasanra merged commit aeda4f6 into release/v2.12.0 Sep 25, 2020
@dasanra dasanra deleted the fix/activate-blacklist-tokens branch September 25, 2020 16:39
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tokens cannot be disabled in the Manage list modal

3 participants