Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

(Bugfix) Owners duplicated#1402

Merged
Agupane merged 2 commits intorelease/v2.12.0from
hotfix/owners-duplicated
Sep 25, 2020
Merged

(Bugfix) Owners duplicated#1402
Agupane merged 2 commits intorelease/v2.12.0from
hotfix/owners-duplicated

Conversation

@Agupane
Copy link
Contributor

@Agupane Agupane commented Sep 25, 2020

Closes #1398

Description

  • Fixes the issue generated by a race condition between checkAndUpdateSafe and sendAddOwner.
  • The main issue was that the addSafeOwner action wasn't avoiding add an owner if it already exists in the owner's list

@Agupane Agupane self-assigned this Sep 25, 2020
@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@Agupane Agupane changed the base branch from development to release/v2.12.0 September 25, 2020 13:47
@github-actions
Copy link

github-actions bot commented Sep 25, 2020

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Sep 25, 2020

Travis automatic deployment:
https://pr1402--safereact.review.gnosisdev.com/app

1 similar comment
@ghost
Copy link

ghost commented Sep 25, 2020

Travis automatic deployment:
https://pr1402--safereact.review.gnosisdev.com/app

Copy link
Contributor

@francovenica francovenica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine. No more duplicated owners in the settings

@Agupane Agupane merged commit c1bc366 into release/v2.12.0 Sep 25, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2020
@Agupane Agupane deleted the hotfix/owners-duplicated branch September 25, 2020 15:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New owners get duplicated

3 participants