Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

Change wording when trying to add an incompatible Safe address#1405

Merged
dasanra merged 6 commits intodevelopmentfrom
enhancement/mastercopy
Sep 28, 2020
Merged

Change wording when trying to add an incompatible Safe address#1405
dasanra merged 6 commits intodevelopmentfrom
enhancement/mastercopy

Conversation

@matextrem
Copy link
Contributor

closes #1381

@matextrem matextrem added the Enhancement ✨ Minor Improvement / changes to existing functionality label Sep 25, 2020
@matextrem matextrem requested a review from dasanra September 25, 2020 23:27
@matextrem matextrem self-assigned this Sep 25, 2020
@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Sep 25, 2020

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 1 0
Ignored 0 N/A
  • Result: ✅ success

  • Annotations: 1 total


[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods


Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Sep 25, 2020

Travis automatic deployment:
https://pr1405--safereact.review.gnosisdev.com/app

@dasanra
Copy link
Collaborator

dasanra commented Sep 28, 2020

@matextrem What happened with this PR? Using a really outdated base? Maybe a git pull is needed in your local machine. I see lot of changes from another PRs that should already be on development

@matextrem
Copy link
Contributor Author

@dasanra Fixed!

@ghost
Copy link

ghost commented Sep 28, 2020

Travis automatic deployment:
https://pr1405--safereact.review.gnosisdev.com/app

Copy link
Collaborator

@dasanra dasanra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @matextrem

@dasanra dasanra merged commit ab1775e into development Sep 28, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2020
@dasanra dasanra deleted the enhancement/mastercopy branch October 20, 2020 08:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Enhancement ✨ Minor Improvement / changes to existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Better wording when trying to add an incompatible Safe address

2 participants