Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

(Feature) Remove automatic load addressbook owners#1406

Merged
Agupane merged 7 commits intodevelopmentfrom
feature/automatic-load-addressbook
Oct 5, 2020
Merged

(Feature) Remove automatic load addressbook owners#1406
Agupane merged 7 commits intodevelopmentfrom
feature/automatic-load-addressbook

Conversation

@Agupane
Copy link
Contributor

@Agupane Agupane commented Sep 28, 2020

Closes #1391

@Agupane Agupane self-assigned this Sep 28, 2020
@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Sep 28, 2020

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 12 0
Ignored 1 N/A
  • Result: ✅ success

  • Annotations: 12 total


[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods


Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Sep 28, 2020

Travis automatic deployment:
https://pr1406--safereact.review.gnosisdev.com/app

@Agupane Agupane requested a review from dasanra September 29, 2020 12:06
@ghost
Copy link

ghost commented Sep 29, 2020

Travis automatic deployment:
https://pr1406--safereact.review.gnosisdev.com/app

@francovenica
Copy link
Contributor

Test:

  • Create a safe giving names to the owners. Checking that the safe and owners are added to the address book
  • Added a new owner to the safe. New owner is added to the address book
  • Edited the name of the safe. The name changes in the address book
  • Created a new safe. Add the address that were added to the address safe in previous test. The names were filled automatically
  • During the creation edited those names filled automatically. They change in the address book and settings > owners list as well.
  • Loaded a safe. Address that were in the addressbook had their names filled automatically
  • Edited the names there and they changed in the address book and settings > owners table as well
  • Removed an address from the address book. Created/loaded a safe and the address deleted did not get a name filled automatically anymore.

Looks good to me

@ghost
Copy link

ghost commented Sep 30, 2020

Travis automatic deployment:
https://pr1406--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Oct 2, 2020

Travis automatic deployment:
https://pr1406--safereact.review.gnosisdev.com/app

@francovenica
Copy link
Contributor

Retested this ticket after the changes, repeating what I've detailed in the previous comment and adding:

  • Replacing an owner in the settings with an account that was already in the address book and editing the name. After the replacement the name was edited in the address book.

Looks good to me

@Agupane
Copy link
Contributor Author

Agupane commented Oct 5, 2020

Retested this ticket after the changes, repeating what I've detailed in the previous comment and adding:

  • Replacing an owner in the settings with an account that was already in the address book and editing the name. After the replacement the name was edited in the address book.

Looks good to me

CC @dasanra

@ghost
Copy link

ghost commented Oct 5, 2020

Travis automatic deployment:
https://pr1406--safereact.review.gnosisdev.com/app

@Agupane Agupane merged commit 8d82086 into development Oct 5, 2020
@Agupane Agupane deleted the feature/automatic-load-addressbook branch October 5, 2020 17:45
@github-actions github-actions bot locked and limited conversation to collaborators Oct 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(Feature) Stop automatic load of addresses in addressBook

3 participants