Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

Collectibles List - Manage list when no collectibles#1419

Merged
nicosampler merged 14 commits intodevelopmentfrom
fix/collectibles-list
Oct 27, 2020
Merged

Collectibles List - Manage list when no collectibles#1419
nicosampler merged 14 commits intodevelopmentfrom
fix/collectibles-list

Conversation

@matextrem
Copy link
Contributor

closes #795

@matextrem matextrem added the Bug 🐛 Something isn't working label Sep 29, 2020
@matextrem matextrem changed the title Collectibles List - Manages list when no collectibles Collectibles List - Manage list when no collectibles Sep 29, 2020
@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@matextrem matextrem self-assigned this Sep 29, 2020
@github-actions
Copy link

github-actions bot commented Sep 29, 2020

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 2 0
Ignored 0 N/A
  • Result: ✅ success

  • Annotations: 2 total


[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods


Report generated by eslint-plus-action

Copy link
Contributor

@fernandomg fernandomg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Except for the .travis.yml change, the other changes look fine to me.

I'll wait for @dasanra review

@ghost
Copy link

ghost commented Sep 29, 2020

Travis automatic deployment:
https://pr1419--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Oct 2, 2020

Travis automatic deployment:
https://pr1419--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Oct 13, 2020

Travis automatic deployment:
https://pr1419--safereact.review.gnosisdev.com/app

@github-actions
Copy link

github-actions bot commented Oct 24, 2020

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Oct 24, 2020

Travis automatic deployment:
https://pr1419--safereact.review.gnosisdev.com/app

@matextrem matextrem requested a review from nicosampler October 24, 2020 17:06
Copy link
Collaborator

@dasanra dasanra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we properly type this component?

There is an example on the needed typos in TokenList already
https://github.com/gnosis/safe-react/blob/development/src/routes/safe/components/Balances/Tokens/screens/TokenList/index.tsx

@ghost
Copy link

ghost commented Oct 26, 2020

Travis automatic deployment:
https://pr1419--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Oct 26, 2020

Travis automatic deployment:
https://pr1419--safereact.review.gnosisdev.com/app

@matextrem matextrem requested a review from dasanra October 26, 2020 15:57
@ghost
Copy link

ghost commented Oct 26, 2020

Travis automatic deployment:
https://pr1419--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Oct 27, 2020

Travis automatic deployment:
https://pr1419--safereact.review.gnosisdev.com/app

@nicosampler nicosampler merged commit cb051b1 into development Oct 27, 2020
@nicosampler nicosampler deleted the fix/collectibles-list branch October 27, 2020 14:53
@github-actions github-actions bot locked and limited conversation to collaborators Oct 27, 2020
@francovenica
Copy link
Contributor

https://pr1419--safereact.review.gnosisdev.com/app/#/safes/0x9efe07fB5C7c537F262Be9dD700f563C7d381fDc/balances/collectibles

So the change is already in prod, and it looks fine
image.png

In the PR itself there are a bunch of pre loaded tokens in the list idk where those came from
image.png

So, I don't know why is in prod already, but it looks fine.

EDIT: After a few mins the tokens loaded in prod as well, so chances are the message will not be seen again I suppose
image.png

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Bug 🐛 Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Manage list when safe has no Collectibles

5 participants