(Feature) [xDai] - Parametrize ethscan values by Agupane · Pull Request #1424 · 5afe/safe-react

Agupane · 2020-10-02T14:42:33Z

Description

Replaces the usages of the old EthHashInfo and Etherscan with the version of the safe-react-components. Now the components don't need the network, both description and network URL will be received on props.

Co-authored-by: Matias Dastugue <matias.dastugue@altoros.com>

…ai-generic-configs

Co-authored-by: Matias Dastugue <matias.dastugue@altoros.com>

…ai-generic-configs

Mock mainnet config

Replaces old EthHashInfo implementation with new implementation

github-actions · 2020-10-02T14:42:49Z

CLA Assistant Lite All Contributors have signed the CLA.

github-actions · 2020-10-02T14:48:04Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	1	N/A

Result: ✅ success
Annotations: 0 total

^{Report generated by eslint-plus-action}

…parametrize-ethscan-values # Conflicts: # src/config/networks/mainnet.ts # src/config/networks/network.d.ts # src/config/networks/rinkeby.ts # src/config/networks/xdai.ts

ghost · 2020-10-05T12:34:48Z

Travis automatic deployment:
https://pr1424--safereact.review.gnosisdev.com/app

src/logic/hooks/useExplorerInfo.tsx

src/config/utils.ts

…rametrize-ethscan-values

fernandomg

@Agupane, there are some missing explorer buttons:

ghost · 2020-10-06T00:31:46Z

Travis automatic deployment:
https://pr1424--safereact.review.gnosisdev.com/app

Agupane · 2020-10-06T12:37:50Z

@Agupane, there are some missing explorer buttons:

Thanks for noticing that, it's ok now

ghost · 2020-10-06T12:44:42Z

Travis automatic deployment:
https://pr1424--safereact.review.gnosisdev.com/app

ghost · 2020-10-06T12:55:53Z

Travis automatic deployment:
https://pr1424--safereact.review.gnosisdev.com/app

Replaces EtherscanButton to ScanBlockButton

ghost · 2020-10-06T14:45:24Z

Travis automatic deployment:
https://pr1424--safereact.review.gnosisdev.com/app

fernandomg

💯 looking great!

src/config/index.ts

…/gnosis/safe-react into feature/#1417-parametrize-ethscan-values # Conflicts: # src/config/index.ts

ghost · 2020-10-06T16:33:45Z

Travis automatic deployment:
https://pr1424--safereact.review.gnosisdev.com/app

ghost · 2020-10-06T16:50:43Z

Travis automatic deployment:
https://pr1424--safereact.review.gnosisdev.com/app

fernandomg and others added 18 commits September 30, 2020 16:33

add network based configs

9ab2060

Co-authored-by: Matias Dastugue <matias.dastugue@altoros.com>

Merge branch 'feature/#1353-xDai-compatibility' into feature/#1414-xD…

fd48894

…ai-generic-configs

Merge branch 'feature/#1353-xDai-compatibility' into feature/#1414-xD…

8adeaf0

…ai-generic-configs

Rename dev config by baseConfig

79fdcd9

use ETHEREUM_NETWORK enum to define the network id

5b90fa9

Co-authored-by: Matias Dastugue <matias.dastugue@altoros.com>

change config keys from CONSTANT_CASE to upperCase

c0859fd

Co-authored-by: Matias Dastugue <matias.dastugue@altoros.com>

replace Host and Url with Uri in config keys

1b39ee1

Co-authored-by: Matias Dastugue <matias.dastugue@altoros.com>

move network config files into a networks directory

79e2a70

Co-authored-by: Matias Dastugue <matias.dastugue@altoros.com>

add tests for config files

ab69f74

Co-authored-by: Matias Dastugue <matias.dastugue@altoros.com>

Merge branch 'feature/#1353-xDai-compatibility' into feature/#1414-xD…

45cb541

…ai-generic-configs

fix test description

9e2e755

Adds useExplorerInfo hook

45a9e87

Mock mainnet config

Sync configs

8377876

Fix useExplorerInfo

ccddaf1

Moves AddressWrapper to another file

0b022c4

Finish useExplorerInfo implementation

d5f1cfd

Adds rinkeby support in config utils.ts

0a43172

Uses useExplorerInfo hook

b9dd0fc

Replaces old EthHashInfo implementation with new implementation

Agupane changed the base branch from development to feature/#1353-xDai-compatibility October 2, 2020 14:43

Agupane changed the title ~~(Feature) [xDai] - arametrize ethscan values~~ (Feature) [xDai] - Parametrize ethscan values Oct 2, 2020

Agupane changed the base branch from feature/#1353-xDai-compatibility to feature/#1414-xDai-generic-configs October 2, 2020 14:47

Agupane and others added 7 commits October 2, 2020 11:55

Merge with feature/#1414-xDai-generic-configs

3d767af

Add support for xDai in getNetworkConfig

728e589

change features' type to boolean

dfd1b2a

replace Uri with Url

dc26462

add networkExplorerName key

35604e7

Make package.json references last version

e046ba5

Merge branch 'feature/#1414-xDai-generic-configs' into feature/#1417-…

2bce4e0

…parametrize-ethscan-values # Conflicts: # src/config/networks/mainnet.ts # src/config/networks/network.d.ts # src/config/networks/rinkeby.ts # src/config/networks/xdai.ts

fernandomg reviewed Oct 5, 2020

View reviewed changes

src/logic/hooks/useExplorerInfo.tsx Outdated Show resolved Hide resolved

fernandomg reviewed Oct 5, 2020

View reviewed changes

src/config/utils.ts Outdated Show resolved Hide resolved

Agupane and others added 2 commits October 5, 2020 09:58

Moves utils to index.ts

0b13c49

Merge branch 'feature/#1353-xDai-compatibility' into feature/#1417-pa…

1052b76

…rametrize-ethscan-values

fernandomg suggested changes Oct 6, 2020

View reviewed changes

Adds missing scanBlock url on EthHashInfo components

6ca3b92

Agupane requested a review from fernandomg October 6, 2020 12:37

Replaces useExplorerInfo.tsx with a normal function

fdde0a4

Replaces scanBlockUrl with explorerUrl

649f7b3

Replaces EtherscanButton to ScanBlockButton

fernandomg removed the request for review from francovenica October 6, 2020 15:35

fernandomg approved these changes Oct 6, 2020

View reviewed changes

Update safe react components version

4df46f3

dasanra suggested changes Oct 6, 2020

View reviewed changes

src/config/index.ts Outdated Show resolved Hide resolved

Agupane added 4 commits October 6, 2020 12:59

Removes undefined in hash parameter on getExplorerInfo

26183a5

Fix tx defined on CreationTx

a9c77c6

Fix undefined checks

40086ae

Remove unnecessary getExplorerInfo on ProviderAccessible.tsx

01ea771

dasanra approved these changes Oct 6, 2020

View reviewed changes

Merge branch 'feature/#1353-xDai-compatibility' of https://github.com…

4c6236c

…/gnosis/safe-react into feature/#1417-parametrize-ethscan-values # Conflicts: # src/config/index.ts

fernandomg merged commit 8c16bce into feature/#1353-xDai-compatibility Oct 6, 2020

fernandomg deleted the feature/#1417-parametrize-ethscan-values branch October 6, 2020 16:51

github-actions bot locked and limited conversation to collaborators Oct 6, 2020

Conversation

Agupane commented Oct 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Uh oh!

github-actions bot commented Oct 2, 2020

Uh oh!

github-actions bot commented Oct 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ESLint Summary View Full Report

Uh oh!

ghost commented Oct 5, 2020

Uh oh!

Uh oh!

Uh oh!

fernandomg left a comment

Choose a reason for hiding this comment

Uh oh!

ghost commented Oct 6, 2020

Uh oh!

Agupane commented Oct 6, 2020

Uh oh!

ghost commented Oct 6, 2020

Uh oh!

ghost commented Oct 6, 2020

Uh oh!

ghost commented Oct 6, 2020

Uh oh!

fernandomg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ghost commented Oct 6, 2020

Uh oh!

ghost commented Oct 6, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Agupane commented Oct 2, 2020 •

edited

Loading

github-actions bot commented Oct 2, 2020 •

edited

Loading