This repository was archived by the owner on Nov 10, 2023. It is now read-only.
(Feature) [xDai] - Contract interaction abi lookup#1429
Merged
fernandomg merged 35 commits intofeature/#1353-xDai-compatibilityfrom Oct 6, 2020
Merged
Conversation
Co-authored-by: Matias Dastugue <matias.dastugue@altoros.com>
…ai-generic-configs
…ai-generic-configs
Co-authored-by: Matias Dastugue <matias.dastugue@altoros.com>
Co-authored-by: Matias Dastugue <matias.dastugue@altoros.com>
Co-authored-by: Matias Dastugue <matias.dastugue@altoros.com>
Co-authored-by: Matias Dastugue <matias.dastugue@altoros.com>
Co-authored-by: Matias Dastugue <matias.dastugue@altoros.com>
…ai-generic-configs
Co-authored-by: Matias Dastugue <matias.dastugue@altoros.com>
Co-authored-by: Matias Dastugue <matias.dastugue@altoros.com>
Co-authored-by: Matias Dastugue <matias.dastugue@altoros.com>
Co-authored-by: Matias Dastugue <matias.dastugue@altoros.com>
…xDai-use-generic-config # Conflicts: # src/config/networks/__tests__/networks.test.ts # src/config/networks/network.d.ts
…ion file Co-authored-by: Matias Dastugue <matias.dastugue@altoros.com>
Co-authored-by: Matias Dastugue <matias.dastugue@altoros.com>
Co-authored-by: Matias Dastugue <matias.dastugue@altoros.com>
- also added 'local' as a network for testing purposes
…ai-use-generic-config # Conflicts: # src/config/networks/__tests__/networks.test.ts # src/config/networks/mainnet.ts # src/config/networks/network.d.ts # src/config/networks/rinkeby.ts # src/config/networks/xdai.ts # src/logic/wallets/getWeb3.ts
Moves getContractABI to src/config/index.ts
|
CLA Assistant Lite All Contributors have signed the CLA. |
Agupane
changed the base branch from
development
to
feature/#1415-xDai-use-generic-config
ESLint Summary View Full Report
Report generated by eslint-plus-action |
|
Travis automatic deployment: |
Agupane
changed the base branch from
feature/#1415-xDai-use-generic-config
to
feature/#1353-xDai-compatibility
…ai-contract-interaction-abi-lookup # Conflicts: # src/config/__tests__/config.test.ts # src/config/index.ts # src/logic/contractInteraction/sources/EtherscanService.ts # src/routes/safe/components/Balances/SendModal/screens/ContractInteraction/utils/index.ts
…ai-contract-interaction-abi-lookup # Conflicts: # src/routes/safe/components/Balances/SendModal/screens/ContractInteraction/utils/index.ts
|
Travis automatic deployment: |
…ai-contract-interaction-abi-lookup
|
Travis automatic deployment: |
fernandomg
approved these changes
Oct 6, 2020
Contributor
fernandomg
left a comment
fernandomg
left a comment
There was a problem hiding this comment.
Tested and worked fine. Left a suggestion, but not a showstopper.
dasanra
approved these changes
Oct 6, 2020
fernandomg
deleted the
feature/#1428-xDai-contract-interaction-abi-lookup
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1428
Depends on #1422