This repository was archived by the owner on Nov 10, 2023. It is now read-only.
(Feature) [xDai] - Visually differentiate networks#1431
Merged
fernandomg merged 46 commits intofeature/#1353-xDai-compatibilityfrom Oct 8, 2020
Merged
Conversation
Co-authored-by: Matias Dastugue <matias.dastugue@altoros.com>
…ai-generic-configs
…ai-generic-configs
Co-authored-by: Matias Dastugue <matias.dastugue@altoros.com>
Co-authored-by: Matias Dastugue <matias.dastugue@altoros.com>
Co-authored-by: Matias Dastugue <matias.dastugue@altoros.com>
Co-authored-by: Matias Dastugue <matias.dastugue@altoros.com>
Co-authored-by: Matias Dastugue <matias.dastugue@altoros.com>
…ai-generic-configs
Co-authored-by: Matias Dastugue <matias.dastugue@altoros.com>
Co-authored-by: Matias Dastugue <matias.dastugue@altoros.com>
Co-authored-by: Matias Dastugue <matias.dastugue@altoros.com>
Co-authored-by: Matias Dastugue <matias.dastugue@altoros.com>
…xDai-use-generic-config # Conflicts: # src/config/networks/__tests__/networks.test.ts # src/config/networks/network.d.ts
…ion file Co-authored-by: Matias Dastugue <matias.dastugue@altoros.com>
Co-authored-by: Matias Dastugue <matias.dastugue@altoros.com>
Co-authored-by: Matias Dastugue <matias.dastugue@altoros.com>
- also added 'local' as a network for testing purposes
…ai-use-generic-config # Conflicts: # src/config/networks/__tests__/networks.test.ts # src/config/networks/mainnet.ts # src/config/networks/network.d.ts # src/config/networks/rinkeby.ts # src/config/networks/xdai.ts # src/logic/wallets/getWeb3.ts
|
Travis automatic deployment: |
Uses networkInfo on CircleDot.tsx
nicosampler
approved these changes
Oct 8, 2020
Contributor
nicosampler
left a comment
nicosampler
left a comment
There was a problem hiding this comment.
I just found an inconsistency in the label we are showing at the top of the sidebar.
For Mainnet it says "Mainnet" which is reasonable
For Rinkenby it says "Rinkeby" which is reasonable
For xDai it says "xDai Stake" which is not consistent with the other, also, IMHO it should not say "Stake"
The code and the Apps look good to me.
…ai-visually-differentiate-networks
Contributor
|
Travis automatic deployment: |
…ai-visually-differentiate-networks # Conflicts: # src/components/App/ReceiveModal.tsx
|
Travis automatic deployment: |
|
Travis automatic deployment: |
dasanra
approved these changes
Oct 8, 2020
fernandomg
deleted the
feature/#1426-xDai-visually-differentiate-networks
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1426
