(Feature) [xDai] - Use tx service for loading token info

[Agupane]

Closes #1407

Description

• Replaces getRelayUrl with getTxServiceUrl
• Removes unused function fetchToken

[github-actions]

CLA Assistant Lite All Contributors have signed the CLA.

[github-actions]

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	2	0
Ignored	6	N/A

• Result: ✅ success

• Annotations: 2 total

  ---

[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods

• src/logic/tokens/api/fetchTokenBalanceList.ts Line 5 - Missing return type on function.
• src/logic/tokens/api/fetchTokenBalanceList.ts Line 5 - Argument 'safeAddress' should be typed.

---

^{Report generated by eslint-plus-action}

[ghost]

Travis automatic deployment:
https://pr1435--safereact.review.gnosisdev.com/app

[fernandomg]

We'll need to filter what's returned, as this service exposes both ERC20 and ERC721 tokens.

Bear in mind that #1408 will serve from this same endpoint, so you can do something reusable for that PR.

[Agupane]

It's fixed now, I just filtered the ERC721, on the PR for #1408 we should aim to use the same function to fetch both of them and save it together into redux and removing the old functions. Didn't want to do it here to make things simpler, let's work on that on the next pr

[ghost]

Travis automatic deployment:
https://pr1435--safereact.review.gnosisdev.com/app

[ghost]

Travis automatic deployment:
https://pr1435--safereact.review.gnosisdev.com/app

[matextrem]

Should we move erc20 string to a constant variable?

[fernandomg]

I don't think it's mandatory now. Probably when we work on #1408 we'll address this in a most consistent way.

[dasanra]

Didn't notice this before, but I see we are not having a convention in API URL parameters. We are adding final slash in some of them but we aren't on the others.

We should stick to not add slash on the end of the API URL parameters so we start the routes with slash.

[fernandomg]

Didn't notice this before, but I see we are not having a convention in API URL parameters. We are adding final slash in some of them but we aren't on the others.

We should stick to not add slash on the end of the API URL parameters so we start the routes with slash.

Ok, good call. Actually, we may have missed some, but we intentionally wanted to add a slash to the end of all the URLs in the config files 😁

[ghost]

Travis automatic deployment:
https://pr1435--safereact.review.gnosisdev.com/app

[ghost]

Travis automatic deployment:
https://pr1435--safereact.review.gnosisdev.com/app