Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

(Feature) [xDai] - Cosmetic fixes#1449

Merged
fernandomg merged 9 commits intofeature/#1353-xDai-compatibilityfrom
feature/#1439-cosmetic-fixes
Oct 9, 2020
Merged

(Feature) [xDai] - Cosmetic fixes#1449
fernandomg merged 9 commits intofeature/#1353-xDai-compatibilityfrom
feature/#1439-cosmetic-fixes

Conversation

@Agupane
Copy link
Contributor

@Agupane Agupane commented Oct 8, 2020

Closes #1439

Looks like this now:

@github-actions
Copy link

github-actions bot commented Oct 8, 2020

CLA Assistant Lite All Contributors have signed the CLA.

@Agupane Agupane changed the base branch from development to feature/#1353-xDai-compatibility October 8, 2020 15:41
@github-actions
Copy link

github-actions bot commented Oct 8, 2020

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 3 0
Ignored 5 N/A
  • Result: ✅ success

  • Annotations: 3 total


[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods


Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Oct 8, 2020

Travis automatic deployment:
https://pr1449--safereact.review.gnosisdev.com/app

1 similar comment
@ghost
Copy link

ghost commented Oct 8, 2020

Travis automatic deployment:
https://pr1449--safereact.review.gnosisdev.com/app

@Agupane Agupane marked this pull request as ready for review October 9, 2020 12:53
…/gnosis/safe-react into feature/#1439-cosmetic-fixes

# Conflicts:
#	src/components/AppLayout/Header/components/NetworkLabel.tsx
#	src/components/AppLayout/Header/components/ProviderDetails/UserDetails.tsx
#	src/config/networks/xdai.ts
@ghost
Copy link

ghost commented Oct 9, 2020

Travis automatic deployment:
https://pr1449--safereact.review.gnosisdev.com/app

@fernandomg fernandomg requested a review from matextrem October 9, 2020 13:13
Copy link
Contributor

@fernandomg fernandomg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good.

I have no strong opinion about using TestNet vs Rinkeby/Volta or whatever the test network name is.

Just let a couple of changes required

network={network}
onDisconnect={onDisconnect}
openDashboard={openDashboard()}
openDashboard={!!openDashboard()}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this prop supposed to do?

By the !! it looks like it should be a boolean value, but from the openDashboard() function return value, it seems to be returning either a false value or a function or an undefined.

Ah... if you see the UserDetails component, openDashboard is being used as a function if it's defined 29f82ea (#1449)

You can either change the UserDetails props type to openDashboard?: boolean | () => void | null and leave it as it was; or split this prop into to props, one for a flag and the other for the function.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's done thanks!

@ghost
Copy link

ghost commented Oct 9, 2020

Travis automatic deployment:
https://pr1449--safereact.review.gnosisdev.com/app

@fernandomg fernandomg self-requested a review October 9, 2020 18:06
@fernandomg fernandomg merged commit e941f1f into feature/#1353-xDai-compatibility Oct 9, 2020
@fernandomg fernandomg deleted the feature/#1439-cosmetic-fixes branch October 9, 2020 18:07
@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[xDai] - Cosmetic fixes based on network

3 participants