(Feature) [xDai] - Cosmetic fixes#1449
(Feature) [xDai] - Cosmetic fixes#1449fernandomg merged 9 commits intofeature/#1353-xDai-compatibilityfrom
Conversation
|
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
[warning] @typescript-eslint/explicit-module-boundary-types
Report generated by eslint-plus-action |
|
Travis automatic deployment: |
1 similar comment
|
Travis automatic deployment: |
…/gnosis/safe-react into feature/#1439-cosmetic-fixes # Conflicts: # src/components/AppLayout/Header/components/NetworkLabel.tsx # src/components/AppLayout/Header/components/ProviderDetails/UserDetails.tsx # src/config/networks/xdai.ts
|
Travis automatic deployment: |
fernandomg
left a comment
There was a problem hiding this comment.
Looking good.
I have no strong opinion about using TestNet vs Rinkeby/Volta or whatever the test network name is.
Just let a couple of changes required
| network={network} | ||
| onDisconnect={onDisconnect} | ||
| openDashboard={openDashboard()} | ||
| openDashboard={!!openDashboard()} |
There was a problem hiding this comment.
what is this prop supposed to do?
By the !! it looks like it should be a boolean value, but from the openDashboard() function return value, it seems to be returning either a false value or a function or an undefined.
Ah... if you see the UserDetails component, openDashboard is being used as a function if it's defined 29f82ea (#1449)
You can either change the UserDetails props type to openDashboard?: boolean | () => void | null and leave it as it was; or split this prop into to props, one for a flag and the other for the function.
|
Travis automatic deployment: |
Closes #1439
Looks like this now: