(Feature) [xDai] - Fetch collectibles from Gnosis services#1460
Conversation
- it doesn't seems to be used anywhere
|
CLA Assistant Lite All Contributors have signed the CLA. |
|
Travis automatic deployment: |
ESLint Summary View Full Report
[warning] @typescript-eslint/explicit-module-boundary-types
Report generated by eslint-plus-action |
|
|
||
| // eslint-disable-next-line react/display-name | ||
| const TokenRow = memo(({ classes, data, index, style }: any) => { | ||
| const TokenRow = memo(({ data, index, style }: any) => { |
| @@ -0,0 +1,6 @@ | |||
| import NFTIcon from 'src/routes/safe/components/Balances/assets/nft_icon.png' | |||
|
|
|||
| export const setCollectibleImageToPlaceholder = (e) => { | |||
There was a problem hiding this comment.
It's possible to type this?
…tch-collectibles-from-tx-service
| this._rateLimit = RateLimit(options.rps, { timeUnit: 60 * 1000, uniformDistribution: true }) | ||
| } | ||
|
|
||
| static extractAssets(assets: TokenResult[], nftTokens: NFTTokens): NFTAssets { |
There was a problem hiding this comment.
I think this name does not represent the functionality. I was thinking is groupNFTPerAddress or something like that.
There was a problem hiding this comment.
yes, that's a naming mess.
NTFAssets aims to be the NFT Family, while the NFTToken aims to be the token itself (which is, actually, the asset).
So, I'll work on that.
Thanks!
There was a problem hiding this comment.
Ok, I'm desisting from doing this change here.
As this comes from the Collectibles first implementation and I'm in the middle of the refactor from nftAssets to nftCollections (and to be honest, I don't even like that name either); and this is getting bigger than I thought and really prone to error.
Personally, it will affect us as developers but won't interfere with the UX. Thus, I'll create a tech-debt task and work that there.
There was a problem hiding this comment.
|
Remember to solve the merge conflicts |
…tch-collectibles-from-tx-service
|
Travis automatic deployment: |
@dasanra, done |
fernandomg
deleted the
feature/#1408-fetch-collectibles-from-tx-service
branch
4 participants
This PR closes #1408, by:
REACT_APP_COLLECTIBLE_SOURCEis not set, it will useGnosis. Currently, this variable can beGnosisorOpenSeaAlso, there was a tiny yet annoying issue with the infura URL: https://github.com/gnosis/safe-react/blob/feature/%231408-fetch-collectibles-from-tx-service/src/config/index.ts#L68 (RPC URL wasn't well constructed)
Finally, this is how it looks by consuming Gnosis service on Rinkeby. There are some missing information (images and names in some cases).