Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

Remove any in src/config/index.ts#1462

Merged
Agupane merged 1 commit intofeature/#1353-xDai-compatibilityfrom
remove-any-config
Oct 13, 2020
Merged

Remove any in src/config/index.ts#1462
Agupane merged 1 commit intofeature/#1353-xDai-compatibilityfrom
remove-any-config

Conversation

@mmv08
Copy link
Contributor

@mmv08 mmv08 commented Oct 12, 2020

This PR:

  • Replaces any with a more strict type

As a general reminder, we shouldn't use any in the new code

@mmv08 mmv08 requested review from Agupane and fernandomg October 12, 2020 08:51
@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 1 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Oct 12, 2020

Travis automatic deployment:
https://pr1462--safereact.review.gnosisdev.com/app

@fernandomg
Copy link
Contributor

@mikheevm great catch, thanks!

This was an existing code moved, and I completely missed checking typings for that change.

@Agupane Agupane merged commit 058e23b into feature/#1353-xDai-compatibility Oct 13, 2020
@Agupane Agupane deleted the remove-any-config branch October 13, 2020 13:39
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants