This repository was archived by the owner on Nov 10, 2023. It is now read-only.
(Feature) [xDai] - Disable safe sections based on network config#1468
Merged
Agupane merged 10 commits intofeature/#1353-xDai-compatibilityfrom Oct 13, 2020
Merged
Conversation
Renames features to disabledFeatures
…bled features by config before return the enabledFeatures result
|
CLA Assistant Lite All Contributors have signed the CLA. |
…/gnosis/safe-react into feature/#1456-disable-safe-sections
ESLint Summary View Full Report
Report generated by eslint-plus-action |
|
Travis automatic deployment: |
nicosampler
reviewed
Oct 13, 2020
nicosampler
reviewed
Oct 13, 2020
nicosampler
reviewed
Oct 13, 2020
| render={() => wrapInSuspense(<TxsTable />, null)} | ||
| /> | ||
| <Route exact path={`${matchSafeWithAddress?.path}/apps`} render={() => wrapInSuspense(<Apps />, null)} /> | ||
| <Route |
Contributor
There was a problem hiding this comment.
I would remove the <Route in case safe-apps are disabled.
{safeAppsEnabled && <Route...
Contributor
There was a problem hiding this comment.
nevermind, I understand why you did this!
nicosampler
approved these changes
Oct 13, 2020
|
Travis automatic deployment: |
1 similar comment
|
Travis automatic deployment: |
dasanra
approved these changes
Oct 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1456
Description
to an array of
disabledFeatures:now this let us add more features that could be disabled in the future without modifying the structure of the config each time
Rinkeby config example that disables SAFE_APPS: