This repository was archived by the owner on Nov 10, 2023. It is now read-only.
Make getExplorerInfo return values per network#1470
Merged
dasanra merged 1 commit intofeature/#1353-xDai-compatibilityfrom Oct 14, 2020
Merged
Make getExplorerInfo return values per network#1470dasanra merged 1 commit intofeature/#1353-xDai-compatibilityfrom
dasanra merged 1 commit intofeature/#1353-xDai-compatibilityfrom
Conversation
|
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
|
Travis automatic deployment: |
Agupane
approved these changes
Oct 14, 2020
dasanra
approved these changes
Oct 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a discussion related to how to deal with
getExplorerInfo(it's a function that returns the explorer URL to inspect an address or transaction). Pablo and I suggested that we should have a separate file in order to define all the functions that should handle a particular case depending on the current network.The intention was that at the moment of creating a new network, a developer should go to
src/configfolder and replicate all the existing files with the new network. Giving it a second thought I think it is an overkill, at the momentgetExplorerInfoit's the only function that needs a special treatment depending on the network.Another alternative is to create another file
utils.ts (?)where we can handle all these particular cases, but we will end having an index.ts and a utils.ts where won't be crystal what's the purpose of each one.What I suggest to do is to make a little refactor in the current
getExplorerInfo. That's what this PR does.