Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

Bump dependencies#1478

Merged
dasanra merged 7 commits intodevelopmentfrom
upgrade-dependencies
Oct 15, 2020
Merged

Bump dependencies#1478
dasanra merged 7 commits intodevelopmentfrom
upgrade-dependencies

Conversation

@dasanra
Copy link
Collaborator

@dasanra dasanra commented Oct 15, 2020

Bump dependencies with minor changes

Remove deprecated dependency for electron
Migrate truffle-contract to latest @truffle/contract

@dasanra dasanra requested a review from mmv08 October 15, 2020 11:00
@dasanra dasanra self-assigned this Oct 15, 2020
@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@rmeissner
Copy link
Contributor

rmeissner commented Oct 15, 2020

should we update truffle contracts too? (we are using a deprecated version)

Edit:
https://www.npmjs.com/package/@truffle/contract is the new one (see https://www.npmjs.com/package/truffle-contract)

@github-actions
Copy link

github-actions bot commented Oct 15, 2020

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 2 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@dasanra
Copy link
Collaborator Author

dasanra commented Oct 15, 2020

@rmeissner will check. I forgot to bump it because of the naming change, if nothing breaks will bump it to the most recent version I can

@ghost
Copy link

ghost commented Oct 15, 2020

Travis automatic deployment:
https://pr1478--safereact.review.gnosisdev.com/app

@rmeissner
Copy link
Contributor

I think it should not break stuff, but we need to update some imports ... might make sense to have this in a separate PR if it is too much. If you prefer I can create an issue ;)

@ghost
Copy link

ghost commented Oct 15, 2020

Travis automatic deployment:
https://pr1478--safereact.review.gnosisdev.com/app

@dasanra dasanra merged commit eab0e73 into development Oct 15, 2020
@dasanra dasanra deleted the upgrade-dependencies branch October 15, 2020 15:01
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants