Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

(Fix) xDai feature issues#1484

Merged
fernandomg merged 3 commits intofeature/#1353-xDai-compatibilityfrom
fix/xdai-feature-issues
Oct 16, 2020
Merged

(Fix) xDai feature issues#1484
fernandomg merged 3 commits intofeature/#1353-xDai-compatibilityfrom
fix/xdai-feature-issues

Conversation

@fernandomg
Copy link
Contributor

@fernandomg fernandomg commented Oct 15, 2020

This PR fixes some issues that were found during the xDai feature testing.

  • app crashes when trying to expand an incoming transaction
  • safe creation URL wrongly formed
  • wrong network name provided to safe-apps

fernandomg and others added 2 commits October 15, 2020 18:02
`CreationTx` receives the tx object every time a row is expanded.
As `tx.creator` does not exist, `getExplorerInfo(tx.creator)` fails to build the url.
Co-authored-by: nicosampler <nf.dominguez.87@gmail.com>
@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Oct 15, 2020

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Oct 15, 2020

Travis automatic deployment:
https://pr1484--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Oct 15, 2020

Travis automatic deployment:
https://pr1484--safereact.review.gnosisdev.com/app

@fernandomg fernandomg marked this pull request as ready for review October 15, 2020 23:17
@fernandomg fernandomg merged commit 13e0cb9 into feature/#1353-xDai-compatibility Oct 16, 2020
@fernandomg fernandomg deleted the fix/xdai-feature-issues branch October 16, 2020 00:03
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants