This repository was archived by the owner on Nov 10, 2023. It is now read-only.

(Feature) - Replaces ETH with network native coin#1491

Merged

Agupane merged 7 commits intofeature/#1353-xDai-compatibilityfrom

feature/#1487-eth-instead-of-xDai

Oct 16, 2020

Contributor

Agupane commented Oct 16, 2020

Closes #1487

Agupane added 4 commits

October 16, 2020 13:46


          Replace old ETH values with native coin

9d632a9


          Replace old ETH values with native coin

419e1c5


          Replace old ETH values with native coin

c552b23


          Replace old ETH values with native coin

5dc96fc

Agupane requested review from dasanra, fernandomg and nicosampler

October 16, 2020 17:17

Agupane self-assigned this

github-actions bot commented Oct 16, 2020

CLA Assistant Lite All Contributors have signed the CLA.

github-actions bot commented Oct 16, 2020 •

edited

Loading

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	2	0
Ignored	0	N/A

Result: ✅ success
Annotations: 2 total

[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods

src/routes/open/components/ReviewInformation/index.tsx Line 144 - Argument 'controls' should be typed.
src/routes/open/components/ReviewInformation/index.tsx Line 144 - Argument 'props' should be typed.

^{Report generated by eslint-plus-action}

ghost commented Oct 16, 2020

Travis automatic deployment:
https://pr1491--safereact.review.gnosisdev.com/app

nicosampler reviewed

View reviewed changes

src/routes/open/components/ReviewInformation/index.tsx Outdated Show resolved Hide resolved

nicosampler reviewed

View reviewed changes

src/routes/safe/components/Apps/components/ConfirmTransactionModal.tsx Outdated Show resolved Hide resolved

fernandomg reviewed

View reviewed changes

src/components/SafeListSidebar/SafeList/AddresWrapper.tsx Outdated Show resolved Hide resolved

fernandomg reviewed

View reviewed changes

src/routes/safe/components/Apps/components/ConfirmTransactionModal.tsx Outdated Show resolved Hide resolved

fernandomg reviewed

View reviewed changes

...tes/safe/components/Balances/SendModal/screens/ContractInteraction/NativeCoinValue/index.tsx Outdated Show resolved Hide resolved

fernandomg reviewed

View reviewed changes

...routes/safe/components/Balances/SendModal/screens/ContractInteraction/SendCustomTx/index.tsx Outdated Show resolved Hide resolved

fernandomg reviewed

View reviewed changes

...routes/safe/components/Balances/SendModal/screens/ContractInteraction/SendCustomTx/index.tsx Outdated Show resolved Hide resolved

fernandomg reviewed

View reviewed changes

src/routes/safe/components/Transactions/TxsTable/ExpandedTx/TxDescription/CustomDescription.tsx Outdated Show resolved Hide resolved

fernandomg reviewed

View reviewed changes

src/routes/safe/components/Transactions/TxsTable/ExpandedTx/TxDescription/CustomDescription.tsx Outdated Show resolved Hide resolved

fernandomg reviewed

View reviewed changes

src/routes/safe/components/Transactions/TxsTable/ExpandedTx/index.tsx Outdated Show resolved Hide resolved

fernandomg reviewed

View reviewed changes

Contributor

fernandomg left a comment

👏 There were like a LOT of hardcoded values. Great job!

Agupane added 3 commits

October 16, 2020 15:43


          Remove networkInfo from the components

2f5b4b1


          Replaces humanReadableValue to fromTokenUnit

5f80016


          Remove typo

ba21d22

Agupane requested review from fernandomg and nicosampler

October 16, 2020 18:48

ghost commented Oct 16, 2020

Travis automatic deployment:
https://pr1491--safereact.review.gnosisdev.com/app

2 similar comments

ghost commented Oct 16, 2020

Travis automatic deployment:
https://pr1491--safereact.review.gnosisdev.com/app

ghost commented Oct 16, 2020

Travis automatic deployment:
https://pr1491--safereact.review.gnosisdev.com/app

fernandomg approved these changes

View reviewed changes

Contributor

fernandomg left a comment

💯

nicosampler approved these changes

View reviewed changes

Agupane merged commit ec80055 into feature/#1353-xDai-compatibility

Agupane deleted the feature/#1487-eth-instead-of-xDai branch

October 16, 2020 19:06

github-actions bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet