Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

(Bug) - #1503 Fix collectibles groups is not removed when the last item from it is sent#1511

Merged
Agupane merged 6 commits intodevelopmentfrom
feature/#1509-erc721-does-not-appear
Oct 26, 2020
Merged

(Bug) - #1503 Fix collectibles groups is not removed when the last item from it is sent#1511
Agupane merged 6 commits intodevelopmentfrom
feature/#1509-erc721-does-not-appear

Conversation

@Agupane
Copy link
Contributor

@Agupane Agupane commented Oct 21, 2020

Closes #1503

@Agupane Agupane self-assigned this Oct 21, 2020
@github-actions
Copy link

github-actions bot commented Oct 21, 2020

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Oct 21, 2020 •
edited
Loading

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Oct 21, 2020

Travis automatic deployment:
https://pr1511--safereact.review.gnosisdev.com/app

@mmv08 mmv08 changed the title (Feature) - #1509 erc721 does not appear (Bug) - #1509 erc721 does not appear Oct 21, 2020
@mmv08
Copy link
Contributor

mmv08 commented Oct 21, 2020

Closes how? What was the problem? Could you please add some description?

@Agupane Agupane changed the title (Bug) - #1509 erc721 does not appear (Bug) - #1503 Fix collectibles groups is not removed when the last item from it is sent Oct 22, 2020
@Agupane
Copy link
Contributor Author

Agupane commented Oct 22, 2020

Closes how? What was the problem? Could you please add some description?

The title got outdated, now I updated it, it solves issue #1503. It was intended to solve #1509 but found that the issue was already fixed while working on it, then I just fixed #1503 :)

fernandomg
fernandomg reviewed Oct 22, 2020
View reviewed changes
@ghost
Copy link

ghost commented Oct 23, 2020

Travis automatic deployment:
https://pr1511--safereact.review.gnosisdev.com/app

@Agupane Agupane requested a review from fernandomg October 23, 2020 15:57
@ghost
Copy link

ghost commented Oct 23, 2020

Travis automatic deployment:
https://pr1511--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Oct 26, 2020

Travis automatic deployment:
https://pr1511--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Oct 26, 2020

Travis automatic deployment:
https://pr1511--safereact.review.gnosisdev.com/app

@francovenica
Copy link
Contributor

francovenica commented Oct 26, 2020

Looks good to me
Safe tested with:

0xf8018825293f5724d671D8F6Dd961023ce0ba52d
0x9913B9180C20C6b0F21B6480c84422F6ebc4B808

Dev:
image.png

This PR:
image.png

@Agupane Agupane merged commit 4ce8917 into development Oct 26, 2020
@Agupane Agupane deleted the feature/#1509-erc721-does-not-appear branch October 26, 2020 13:58
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers

@fernandomg fernandomg fernandomg approved these changes

@francovenica francovenica francovenica approved these changes

@dasanra dasanra dasanra approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Agupane Agupane

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

xDai: Collectibles groups is not removed when the last item from it is sent

5 participants

@Agupane @mmv08 @francovenica @fernandomg @dasanra