Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

Add config for EWC and Volta#1513

Merged
dasanra merged 35 commits intodevelopmentfrom
issue-1253
Oct 28, 2020
Merged

Add config for EWC and Volta#1513
dasanra merged 35 commits intodevelopmentfrom
issue-1253

Conversation

@nicosampler
Copy link
Contributor

No description provided.

@nicosampler nicosampler self-assigned this Oct 21, 2020
@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Oct 21, 2020

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 1 0
Ignored 3 N/A
  • Result: ✅ success

  • Annotations: 1 total


[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods


Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Oct 21, 2020

Travis automatic deployment:
https://pr1513--safereact.review.gnosisdev.com/app

Copy link
Collaborator

@dasanra dasanra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment.

energy_web_chain file and import naming should be in camelCase

@nicosampler nicosampler changed the base branch from issue-1498 to development October 22, 2020 13:32
@ghost
Copy link

ghost commented Oct 22, 2020

Travis automatic deployment:
https://pr1513--safereact.review.gnosisdev.com/app

1 similar comment
@ghost
Copy link

ghost commented Oct 22, 2020

Travis automatic deployment:
https://pr1513--safereact.review.gnosisdev.com/app

@dasanra dasanra self-requested a review October 22, 2020 14:18
@nicosampler
Copy link
Contributor Author

Just one comment.

energy_web_chain file and import naming should be in camelCase

Dani, I had to rollback the filename. As the name is inferred from the enum ETHEREUM_NETWORK, the tests were failing because they expected energy_web_token as the export name. If we want to change the enum, we should also change the SDK. So I suggest to left the name as energy_web_token.ts

@ghost
Copy link

ghost commented Oct 22, 2020

Travis automatic deployment:
https://pr1513--safereact.review.gnosisdev.com/app

1 similar comment
@ghost
Copy link

ghost commented Oct 22, 2020

Travis automatic deployment:
https://pr1513--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Oct 22, 2020

Travis automatic deployment:
https://pr1513--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Oct 23, 2020

Travis automatic deployment:
https://pr1513--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Oct 23, 2020

Travis automatic deployment:
https://pr1513--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Oct 23, 2020

Travis automatic deployment:
https://pr1513--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Oct 23, 2020

Travis automatic deployment:
https://pr1513--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Oct 23, 2020

Travis automatic deployment:
https://pr1513--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Oct 23, 2020

Travis automatic deployment:
https://pr1513--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Oct 23, 2020

Travis automatic deployment:
https://pr1513--safereact.review.gnosisdev.com/rinkeby/app

@dasanra
Copy link
Collaborator

dasanra commented Oct 26, 2020

Before merging this we are waiting to have staging / production containers. Until then testing can be done in PR link

@ghost
Copy link

ghost commented Oct 27, 2020

Travis automatic deployment:
https://pr1513--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Oct 27, 2020

Travis automatic deployment:
https://pr1513--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Oct 27, 2020

Travis automatic deployment:
https://pr1513--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Oct 27, 2020

Travis automatic deployment:
https://pr1513--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Oct 27, 2020

Travis automatic deployment:
https://pr1513--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Oct 27, 2020

Travis automatic deployment:
https://pr1513--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Oct 28, 2020

Travis automatic deployment:
https://pr1513--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Oct 28, 2020

Travis automatic deployment:
https://pr1513--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Oct 28, 2020

Travis automatic deployment:
https://pr1513--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Oct 28, 2020

Travis automatic deployment:
https://pr1513--safereact.review.gnosisdev.com/rinkeby/app

@dasanra dasanra merged commit 0278722 into development Oct 28, 2020
@dasanra dasanra deleted the issue-1253 branch October 28, 2020 12:10
@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants