Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

Update calculateGasPrice to fetch from config#1517

Merged
dasanra merged 6 commits intodevelopmentfrom
fix/use-gas-oracle-from-config
Oct 23, 2020
Merged

Update calculateGasPrice to fetch from config#1517
dasanra merged 6 commits intodevelopmentfrom
fix/use-gas-oracle-from-config

Conversation

@dasanra
Copy link
Collaborator

@dasanra dasanra commented Oct 22, 2020

This fixes #1514

We are ignoring provided gasPrice or gasPriceOracleUrl from configuration and just using ethgasstation estimation

@dasanra dasanra added Bug 🐛 Something isn't working Critical Only for bugs in released apps, needs to be fixed asap and hotfix needs to be shipped. labels Oct 22, 2020
@dasanra dasanra self-assigned this Oct 22, 2020
@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Oct 22, 2020

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 6 0
Ignored 5 N/A
  • Result: ✅ success

  • Annotations: 6 total


[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods


Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Oct 22, 2020

Travis automatic deployment:
https://pr1517--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Oct 22, 2020

Travis automatic deployment:
https://pr1517--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Oct 22, 2020

Travis automatic deployment:
https://pr1517--safereact.review.gnosisdev.com/app

Copy link
Contributor

@nicosampler nicosampler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a comment

@dasanra dasanra requested a review from nicosampler October 23, 2020 10:12
@ghost
Copy link

ghost commented Oct 23, 2020

Travis automatic deployment:
https://pr1517--safereact.review.gnosisdev.com/app

@dasanra dasanra merged commit 5f3a9ef into development Oct 23, 2020
@dasanra dasanra deleted the fix/use-gas-oracle-from-config branch October 23, 2020 15:18
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Bug 🐛 Something isn't working Critical Only for bugs in released apps, needs to be fixed asap and hotfix needs to be shipped.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make use of gasPriceOracleUrl | gasPrice to calculate the gas

3 participants