Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

Feature #1480: Handle rpc calls from apps SDK#1519

Merged
mmv08 merged 32 commits intodevelopmentfrom
feature/1480-handle-rpc-calls-from-apps-sdk
Oct 26, 2020
Merged

Feature #1480: Handle rpc calls from apps SDK#1519
mmv08 merged 32 commits intodevelopmentfrom
feature/1480-handle-rpc-calls-from-apps-sdk

Conversation

@mmv08
Copy link
Contributor

@mmv08 mmv08 commented Oct 22, 2020

This PR:

For testing you can use https://github.com/gnosis/safe-test-app, I added a tab with all the rpc calls to the app

@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@github-actions
Copy link

github-actions bot commented Oct 22, 2020

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Oct 22, 2020

Travis automatic deployment:
https://pr1519--safereact.review.gnosisdev.com/app

@mmv08 mmv08 marked this pull request as ready for review October 22, 2020 14:01
jsonrpc: '2.0',
method: payload?.call,
params: payload?.params,
id: '1',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

out of curiosity, why won't it generate a conflict? shouldn't we make it somehow dynamic?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The id is required to be defined by json rpc specification, but our callback is already mapped to a request, so I don’t think it will cause any conflict. Let’s ask @rmeissner if he could confirm it

@ghost
Copy link

ghost commented Oct 23, 2020

Travis automatic deployment:
https://pr1519--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Oct 23, 2020

Travis automatic deployment:
https://pr1519--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Oct 23, 2020

Travis automatic deployment:
https://pr1519--safereact.review.gnosisdev.com/app

@mmv08 mmv08 merged commit 1c53167 into development Oct 26, 2020
@mmv08 mmv08 deleted the feature/1480-handle-rpc-calls-from-apps-sdk branch October 26, 2020 09:53
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Handle RPC_CALL messages from safe apps sdk

3 participants