Feature #1480: Handle rpc calls from apps SDK#1519
Conversation
…re/21-allow-specifying-safetxgas
…re/21-allow-specifying-safetxgas
…osis/safe-react into feature/1480-handle-rpc-calls-from-apps-sdk
…re/1480-handle-rpc-calls-from-apps-sdk
|
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
…re/1480-handle-rpc-calls-from-apps-sdk
…com:gnosis/safe-react into feature/1480-handle-rpc-calls-from-apps-sdk
|
Travis automatic deployment: |
src/routes/safe/components/Apps/hooks/useIframeMessageHandler.ts
Outdated
Show resolved
Hide resolved
| jsonrpc: '2.0', | ||
| method: payload?.call, | ||
| params: payload?.params, | ||
| id: '1', |
There was a problem hiding this comment.
out of curiosity, why won't it generate a conflict? shouldn't we make it somehow dynamic?
There was a problem hiding this comment.
The id is required to be defined by json rpc specification, but our callback is already mapped to a request, so I don’t think it will cause any conflict. Let’s ask @rmeissner if he could confirm it
src/routes/safe/components/Apps/hooks/useIframeMessageHandler.ts
Outdated
Show resolved
Hide resolved
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
This PR:
RPC_CALLmessage which passes the payload to read-only web3 providersendmethodFor testing you can use https://github.com/gnosis/safe-test-app, I added a tab with all the rpc calls to the app