Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

Fix token balances after sending out all tokens#1521

Merged
dasanra merged 3 commits intodevelopmentfrom
fix/#1423-token-balance-not-correctly-updated
Oct 26, 2020
Merged

Fix token balances after sending out all tokens#1521
dasanra merged 3 commits intodevelopmentfrom
fix/#1423-token-balance-not-correctly-updated

Conversation

@dasanra
Copy link
Collaborator

@dasanra dasanra commented Oct 22, 2020

Fixes #1423
Tokens balances aren't updating after sending out all tokens.
There was an issue updating the state for a token that had balance 0

@dasanra dasanra requested a review from nicosampler October 22, 2020 14:59
@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@dasanra dasanra requested review from fernandomg and mmv08 October 22, 2020 15:00
@github-actions
Copy link

github-actions bot commented Oct 22, 2020

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Oct 22, 2020

Travis automatic deployment:
https://pr1521--safereact.review.gnosisdev.com/app

@ghost
Copy link

ghost commented Oct 22, 2020

Travis automatic deployment:
https://pr1521--safereact.review.gnosisdev.com/app

@dasanra dasanra self-assigned this Oct 23, 2020
@francovenica
Copy link
Contributor

Tested here: https://pr1521--safereact.review.gnosisdev.com/app/#/safes/0x34Ae3245101AC7cF1f805E946C73F33B9286B010/balances

Transfer a few different tokens
Transfer a certain amount of those tokens first. Checked that the tokens would be reduced by that amount
Transfer the whole funds of those tokens. Checked that the token fund are now 0 after those transfers

Looks good to me
image.png

@francovenica francovenica self-requested a review October 23, 2020 19:12
@ghost
Copy link

ghost commented Oct 26, 2020

Travis automatic deployment:
https://pr1521--safereact.review.gnosisdev.com/app

@dasanra dasanra merged commit 95d102d into development Oct 26, 2020
@dasanra dasanra deleted the fix/#1423-token-balance-not-correctly-updated branch October 26, 2020 10:34
@github-actions github-actions bot locked and limited conversation to collaborators Oct 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Token balance not correctly updated after sending out tokens

3 participants