Add Sentry config and ErrorBoundary Component by nicosampler · Pull Request #1528 · 5afe/safe-react

nicosampler · 2020-10-26T19:02:55Z

Closes #1289.

Add basic config for Sentry. (react-router and components optimization are not included
Add ErrorBoundary config
Design for ErrorBoundary page. (@alongoni Let me know if you need help in order to force an error)
It needs some environment configuration @dasanra will work on that.
it needs some configuration so Travis only uploads source-code when a release is done

github-actions · 2020-10-26T19:03:10Z

CLA Assistant Lite All Contributors have signed the CLA.

github-actions · 2020-10-26T19:08:06Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

Result: ✅ success
Annotations: 0 total

^{Report generated by eslint-plus-action}

ghost · 2020-10-27T11:29:56Z

Travis automatic deployment:
https://pr1528--safereact.review.gnosisdev.com/app

ghost · 2020-10-27T14:10:57Z

Travis automatic deployment:
https://pr1528--safereact.review.gnosisdev.com/app

ghost · 2020-10-27T14:28:47Z

Travis automatic deployment:
https://pr1528--safereact.review.gnosisdev.com/app

ghost · 2020-10-27T14:47:10Z

Travis automatic deployment:
https://pr1528--safereact.review.gnosisdev.com/app

src/components/GlobalErrorBoundary/index.tsx

ghost · 2020-10-28T11:34:33Z

Travis automatic deployment:
https://pr1528--safereact.review.gnosisdev.com/app

ghost · 2020-10-28T12:33:27Z

Travis automatic deployment:
https://pr1528--safereact.review.gnosisdev.com/rinkeby/app

mmv08 · 2020-10-28T13:39:33Z

src/components/GlobalErrorBoundary/index.tsx

+        <Button
+          size="md"
+          color="primary"
+          onClick={() => {
+            window.location.href = '/app/'
+          }}
+        >
+          Go to Landing
+        </Button>


This is a link

right, we should add a Link component in Components. And make it possible to look like a button.

@mikheevm do you know if we already have a link with the styles of a button in Gnosis? otherwise, I would leave it as it is and create a ticket in Components

Ticket created 5afe/safe-react-components#72.

@mikheevm I just started the ticket to add the Link component, but, should we use links as buttons? Technically we could, we only need to "copy" all the material-ui styles for the button and apply them to the anchor element. But does it make sense? shouldn't we use the links with a different style than buttons? they are used for different actions so it's reasonable they should use different styles.

What I'm suggesting is that we should change the button and use the link style, like in here:

cc: @tschubotz @fernandomg @dasanra @Agupane

TLTR, I think we should separate the actions from navigation, meaning, if we want to move inside the page or to another page, we should use links with link styles. If we want to trigger an action, we should use buttons with button styles.

Giving a quick review of the app the only inconsistency I found was in the nav of each section:

It should have the button style.

ghost · 2020-10-29T14:30:55Z

Travis automatic deployment:
https://pr1528--safereact.review.gnosisdev.com/rinkeby/app

ghost · 2020-10-29T15:03:21Z

Travis automatic deployment:
https://pr1528--safereact.review.gnosisdev.com/rinkeby/app

…1289

ghost · 2020-10-29T15:41:08Z

Travis automatic deployment:
https://pr1528--safereact.review.gnosisdev.com/rinkeby/app

ghost · 2020-10-29T16:24:01Z

Travis automatic deployment:
https://pr1528--safereact.review.gnosisdev.com/rinkeby/app

ghost · 2020-10-29T18:17:10Z

Travis automatic deployment:
https://pr1528--safereact.review.gnosisdev.com/rinkeby/app

fernandomg · 2020-10-29T21:20:52Z

@nicosampler, I think that the case for when we know the address and redirect to the /balances page is not working. See #1289 (comment)

This invalid URL redirects to https://pr1528--safereact.review.gnosisdev.com/rinkeby/app/, given that the safe address is valid

nicosampler · 2020-10-30T16:21:59Z

@fernandomg pushed the fix, can you check it now, please?

ghost · 2020-10-30T16:49:13Z

Travis automatic deployment:
https://pr1528--safereact.review.gnosisdev.com/rinkeby/app

fernandomg · 2020-10-30T17:19:06Z

pushed the fix, can you check it now, please?

@nicosampler It works fine.

Something I want to understand, as I interpreted the requirements a bit differently.

I thought that the error page will be shown, and when clicking 'go home' it would redirect to /balances or /welcome page.

By "known safe" I understood something around querying the tx-service (safes/{safeAddress}/) for the Safe's info.

If the service does not recognize the Safe, we redirect to /welcome, else /balances.

That way, if I enter an EOA or any address, it will prevent loading the Safe App if it's not a known Safe Address for the current environment.

nicosampler · 2020-10-30T17:44:45Z

pushed the fix, can you check it now, please?

@nicosampler It works fine.

Something I want to understand, as I interpreted the requirements a bit differently.

I thought that the error page will be shown, and when clicking 'go home' it would redirect to /balances or /welcome page.

By "known safe" I understood something around querying the tx-service (safes/{safeAddress}/) for the Safe's info.

If the service does not recognize the Safe, we redirect to /welcome, else /balances.

That way, if I enter an EOA or any address, it will prevent loading the Safe App if it's not a known Safe Address for the current environment.

@fernandomg I think we never talked about that flow but seems an interesting idea.

The idea of this ticket was:

if something goes wrong, we show a page error.
if the user enters a not known page, let's say http://localhost:3000/app#/something, we redirect to http://localhost:3000/app#/welcome
if the user enters a not known subpath for a safe or just a safe, we redirect to /balances. (that's the issue you reported yesterday)

I think we should create a ticket for the flow you are proposing

Agupane

LGTM 💯

ghost · 2020-10-30T19:53:28Z

Travis automatic deployment:
https://pr1528--safereact.review.gnosisdev.com/rinkeby/app

Add Sentry config and ErrorBoundary Component

6fc980e

nicosampler assigned nicosampler, dasanra and alongoni Oct 26, 2020

Merge branch 'development' into issue-1289

c1a83ab

nicosampler requested review from dasanra and fernandomg October 26, 2020 19:48

Daniel Sanchez added 3 commits October 27, 2020 11:31

Fix typo issue in Sentry parameter

c25c7f9

Update travis file to upload sentry sourcemaps

c6b0886

Add parameters for sentry project on rinkeby

4874dfb

force sentry error

3c5766c

nicosampler and others added 2 commits October 27, 2020 11:14

anoter way to fail

fa9c137

Merge branch 'development' into issue-1289

a5ee00e

remove forced error

bd0dceb

nicosampler mentioned this pull request Oct 27, 2020

Crash logging #1289

Closed

mmv08 reviewed Oct 27, 2020

View reviewed changes

src/components/GlobalErrorBoundary/index.tsx Outdated Show resolved Hide resolved

Merge branch 'development' into issue-1289

fa82376

Merge remote-tracking branch 'origin/development' into issue-1289

861a3fe

Add Sentry for Volta

8debea1

mmv08 reviewed Oct 28, 2020

View reviewed changes

nicosampler added 2 commits October 28, 2020 10:40

Add design implementation for ErrorBoundary

ac09e3b

remove forced error

3373ca8

Change semicolon

8da34e5

nicosampler requested review from Agupane, dasanra, fernandomg and mmv08 October 29, 2020 15:23

nicosampler added 2 commits October 29, 2020 12:25

move isProdction to constants file

f786a5e

Merge branch 'issue-1289' of github.com:gnosis/safe-react into issue-…

92c24c0

…1289

Daniel Sanchez added 2 commits October 29, 2020 16:50

Simplofy travis if check

9373fc7

Add semiculons

df36180

change Button for Link

84f7f1f

fix redirect when safeAddress is provided but not a subpath for it.

97a1a7f

dasanra approved these changes Oct 30, 2020

View reviewed changes

Agupane approved these changes Oct 30, 2020

View reviewed changes

fernandomg approved these changes Oct 30, 2020

View reviewed changes

dasanra changed the base branch from development to release/v2.14.0 October 30, 2020 19:31

Merge remote-tracking branch 'origin/release/v2.14.0' into issue-1289

f1c0085

dasanra merged commit df42b36 into release/v2.14.0 Oct 30, 2020

dasanra deleted the issue-1289 branch October 30, 2020 19:55

github-actions bot locked and limited conversation to collaborators Oct 30, 2020

Conversation

nicosampler commented Oct 26, 2020 • edited by dasanra Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 26, 2020

Uh oh!

github-actions bot commented Oct 26, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ESLint Summary View Full Report

Uh oh!

ghost commented Oct 27, 2020

Uh oh!

ghost commented Oct 27, 2020

Uh oh!

ghost commented Oct 27, 2020

Uh oh!

ghost commented Oct 27, 2020

Uh oh!

Uh oh!

ghost commented Oct 28, 2020

Uh oh!

ghost commented Oct 28, 2020

Uh oh!

mmv08 Oct 28, 2020

Choose a reason for hiding this comment

Uh oh!

nicosampler Oct 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nicosampler Oct 28, 2020

Choose a reason for hiding this comment

Uh oh!

nicosampler Oct 28, 2020

Choose a reason for hiding this comment

Uh oh!

nicosampler Oct 29, 2020

Choose a reason for hiding this comment

Uh oh!

nicosampler Oct 29, 2020

Choose a reason for hiding this comment

Uh oh!

nicosampler Oct 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ghost commented Oct 29, 2020

Uh oh!

ghost commented Oct 29, 2020

Uh oh!

ghost commented Oct 29, 2020

Uh oh!

ghost commented Oct 29, 2020

Uh oh!

ghost commented Oct 29, 2020

Uh oh!

fernandomg commented Oct 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nicosampler commented Oct 30, 2020

Uh oh!

ghost commented Oct 30, 2020

Uh oh!

fernandomg commented Oct 30, 2020

Uh oh!

nicosampler commented Oct 30, 2020

Uh oh!

Agupane left a comment

Choose a reason for hiding this comment

Uh oh!

ghost commented Oct 30, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

nicosampler commented Oct 26, 2020 •

edited by dasanra

Loading

github-actions bot commented Oct 26, 2020 •

edited

Loading

nicosampler Oct 28, 2020 •

edited

Loading

nicosampler Oct 29, 2020 •

edited

Loading

fernandomg commented Oct 29, 2020 •

edited

Loading