Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

(Feature) - #1531 EWC estimate fee on modal#1543

Merged
dasanra merged 2 commits intorelease/v2.14.0from
feature/1531-ewc-estimate-fee
Oct 30, 2020
Merged

(Feature) - #1531 EWC estimate fee on modal#1543
dasanra merged 2 commits intorelease/v2.14.0from
feature/1531-ewc-estimate-fee

Conversation

@Agupane
Copy link
Contributor

@Agupane Agupane commented Oct 29, 2020

Closes #1531

Description

  • The gas station for EWC seems to have a rounding problem and they are always returning 0, we added a fixed value for EWC of 1e6 while EWC team check it, meanwhile I also opened an issue for the ewc team with the possible error (credits to @fernandomg)

@Agupane Agupane requested review from dasanra and fernandomg October 29, 2020 15:41
@Agupane Agupane self-assigned this Oct 29, 2020
@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 2 0
Ignored 1 N/A
  • Result: ✅ success

  • Annotations: 2 total


[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods


Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Oct 29, 2020

Travis automatic deployment:
https://pr1543--safereact.review.gnosisdev.com/rinkeby/app

@dasanra dasanra changed the base branch from development to release/v2.14.0 October 30, 2020 19:30
@dasanra dasanra merged commit 503b999 into release/v2.14.0 Oct 30, 2020
@dasanra dasanra deleted the feature/1531-ewc-estimate-fee branch October 30, 2020 19:30
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EWC - The modal cannot calculate the estimated fee

3 participants