Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

(Feature) - #1541 etherscan on ewc#1544

Merged
Agupane merged 4 commits intorelease/v2.14.0from
feature/1541-etherscan-on-ewc
Oct 30, 2020
Merged

(Feature) - #1541 etherscan on ewc#1544
Agupane merged 4 commits intorelease/v2.14.0from
feature/1541-etherscan-on-ewc

Conversation

@Agupane
Copy link
Contributor

@Agupane Agupane commented Oct 29, 2020

Closes #1541

Description

  • There were a lot of places in which we were still using the old EtherscanButton, I replaced them with the ExplorerButton from safe react components, now all the links to explorer's should be fine

@Agupane Agupane self-assigned this Oct 29, 2020
@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 8 0
Ignored 0 N/A
  • Result: ✅ success

  • Annotations: 8 total


[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods


Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Oct 29, 2020

Travis automatic deployment:
https://pr1544--safereact.review.gnosisdev.com/rinkeby/app

Copy link
Contributor

@fernandomg fernandomg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@dasanra dasanra changed the base branch from development to release/v2.14.0 October 30, 2020 18:42
@Agupane Agupane merged commit 3fa0b74 into release/v2.14.0 Oct 30, 2020
@Agupane Agupane deleted the feature/1541-etherscan-on-ewc branch October 30, 2020 19:25
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[EWC/Volta] Places with Etherscan data instead of EWC

3 participants