(Fix) Executed transactions status by fernandomg · Pull Request #1552 · 5afe/safe-react

fernandomg · 2020-10-30T23:42:25Z

This PR closes #1490 also, closes #1501, and closes #1342 too, by:

extracting the logic to create the "pending tx" and it's corresponding successful status into a pendingTransactions.ts actions file.
creating two main actions:
- storeSignedTx which is the tx to be executed but still not mined, aka "pending tx",
- storeExecutedTx which will optimistically update the "pending tx" with the tx receipt
fixing types
fixing decoded values

- also added types

github-actions · 2020-10-30T23:42:38Z

CLA Assistant Lite All Contributors have signed the CLA.

github-actions · 2020-10-30T23:47:08Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	1	N/A

Result: ✅ success
Annotations: 0 total

^{Report generated by eslint-plus-action}

ghost · 2020-10-30T23:56:48Z

Travis automatic deployment:
https://pr1552--safereact.review.gnosisdev.com/rinkeby/app

ghost · 2020-10-30T23:58:27Z

Travis automatic deployment:
https://pr1552--safereact.review.gnosisdev.com/rinkeby/app

dasanra · 2020-11-02T10:36:15Z

src/routes/safe/components/Transactions/TxsTable/Status/index.tsx

  awaiting_execution: 'Awaiting execution',
  pending: 'Pending',
-}
+  cacatua: 'Cacatúa',


May I ask? 😅

maybe we can leave it and do this

if (Math.random() < 0.01) { status = status.cacatua }

hahaha 🤦‍♂️

fixed, thanks! 🐦

- bye bye birdie

ghost · 2020-11-02T14:32:30Z

Travis automatic deployment:
https://pr1552--safereact.review.gnosisdev.com/rinkeby/app

ghost · 2020-11-02T15:47:38Z

Travis automatic deployment:
https://pr1552--safereact.review.gnosisdev.com/rinkeby/app

Agupane

💯 🚀

Agupane · 2020-11-02T18:29:57Z

src/logic/safe/store/actions/processTransaction.ts

-import { makeConfirmation } from 'src/logic/safe/store/models/confirmation'
+import { storeExecutedTx, storeSignedTx, storeTx } from 'src/logic/safe/store/actions/transactions/pendingTransactions'

 const processTransaction = ({ approveAndExecute, notifiedTransaction, safeAddress, tx, userAddress }) => async (


If you can type this too that would be nice, if results complicated just leave it for later

- based on `createTransaction` action types

ghost · 2020-11-02T19:45:39Z

Travis automatic deployment:
https://pr1552--safereact.review.gnosisdev.com/rinkeby/app

matextrem

LGTM 👍

ghost · 2020-11-03T17:40:19Z

Travis automatic deployment:
https://pr1552--safereact.review.gnosisdev.com/volta/app

ghost · 2020-11-03T17:40:31Z

Travis automatic deployment:
https://pr1552--safereact.review.gnosisdev.com/rinkeby/app

…0-tx-status

ghost · 2020-11-03T19:16:59Z

Travis automatic deployment:
https://pr1552--safereact.review.gnosisdev.com/rinkeby/app

ghost · 2020-11-03T19:17:51Z

Travis automatic deployment:
https://pr1552--safereact.review.gnosisdev.com/volta/app

ghost · 2020-11-04T14:00:16Z

Travis automatic deployment:
https://pr1552--safereact.review.gnosisdev.com/rinkeby/app

ghost · 2020-11-04T14:00:23Z

Travis automatic deployment:
https://pr1552--safereact.review.gnosisdev.com/volta/app

francovenica · 2020-11-04T21:53:02Z

Stats looks good now.
For 1 owner it will show the tx right away with the pending status

For 2 or more owners. The mock transaction has been gone for a while so after a few secs the tx just show up with the "Awaiting confirmations" status.
When a the final signature is being done, the pending status shows next to the owners address and in the tx status.
Same as before happens for a rejection: the first signature just won't show a change in status, the last signature will show the person who signs and the tx itself with the "Pending" status.

If there are 3 or more people. Any tx signed "off-chain" won't trigger a change in the tx status.

Looks good to me

fernandomg added 5 commits October 30, 2020 20:18

use selectors in mockTransaction function

16d6ea6

update isSuccessful type

8464c4d

update Status component with useStyles hook

6b1fc98

- also added types

extract pendingTransaction actions to a dedicated file

f6077da

fix removeOwner decoded values

c129424

fernandomg requested review from Agupane, dasanra, matextrem, mmv08 and nicosampler October 30, 2020 23:42

fernandomg self-assigned this Oct 30, 2020

Merge branch 'development' into fix/1490-tx-status

0543a47

dasanra reviewed Nov 2, 2020

View reviewed changes

fernandomg added 2 commits November 2, 2020 11:16

remove cacatua status

a6e6ce2

- bye bye birdie

fix tx status update on Tx remove

13a4516

Merge branch 'development' into fix/1490-tx-status

6c92879

fernandomg requested a review from francovenica November 2, 2020 16:06

Agupane approved these changes Nov 2, 2020

View reviewed changes

fernandomg added 3 commits November 2, 2020 16:17

Merge branch 'development' into fix/1490-tx-status

00030b9

add typing to processTransaction action

e99e71d

- based on `createTransaction` action types

fix wording

1666e9a

matextrem approved these changes Nov 2, 2020

View reviewed changes

pablofullana requested a review from dasanra November 3, 2020 14:51

nicosampler approved these changes Nov 3, 2020

View reviewed changes

Merge branch 'development' into fix/1490-tx-status

4a10abc

fernandomg added 3 commits November 3, 2020 15:50

prevent updating confirmations if owner is already in the list

9fd3b20

Merge branch 'development' into fix/1490-tx-status

93dd6ac

Merge remote-tracking branch 'origin/fix/1490-tx-status' into fix/149…

4e8ab9f

…0-tx-status

Merge branch 'development' into fix/1490-tx-status

1bfb8f9

dasanra approved these changes Nov 4, 2020

View reviewed changes

francovenica approved these changes Nov 4, 2020

View reviewed changes

fernandomg merged commit 7a88153 into development Nov 4, 2020

fernandomg deleted the fix/1490-tx-status branch November 4, 2020 22:41

github-actions bot locked and limited conversation to collaborators Nov 4, 2020

Conversation

fernandomg commented Oct 30, 2020

Uh oh!

github-actions bot commented Oct 30, 2020

Uh oh!

github-actions bot commented Oct 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ESLint Summary View Full Report

Uh oh!

ghost commented Oct 30, 2020

Uh oh!

ghost commented Oct 30, 2020

Uh oh!

dasanra Nov 2, 2020

Choose a reason for hiding this comment

Uh oh!

mmv08 Nov 2, 2020

Choose a reason for hiding this comment

Uh oh!

fernandomg Nov 2, 2020

Choose a reason for hiding this comment

Uh oh!

fernandomg Nov 2, 2020

Choose a reason for hiding this comment

Uh oh!

ghost commented Nov 2, 2020

Uh oh!

ghost commented Nov 2, 2020

Uh oh!

Agupane left a comment

Choose a reason for hiding this comment

Uh oh!

Agupane Nov 2, 2020

Choose a reason for hiding this comment

Uh oh!

fernandomg Nov 2, 2020

Choose a reason for hiding this comment

Uh oh!

ghost commented Nov 2, 2020

Uh oh!

matextrem left a comment

Choose a reason for hiding this comment

Uh oh!

ghost commented Nov 3, 2020

Uh oh!

ghost commented Nov 3, 2020

Uh oh!

ghost commented Nov 3, 2020

Uh oh!

ghost commented Nov 3, 2020

Uh oh!

ghost commented Nov 4, 2020

Uh oh!

ghost commented Nov 4, 2020

Uh oh!

francovenica commented Nov 4, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

github-actions bot commented Oct 30, 2020 •

edited

Loading