Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

Updates bnc-notify version and adds support for GridPlus Lattice [internal]#1569

Merged
dasanra merged 4 commits intodevelopmentfrom
GridPlus-gridplus/lattice
Nov 5, 2020
Merged

Updates bnc-notify version and adds support for GridPlus Lattice [internal]#1569
dasanra merged 4 commits intodevelopmentfrom
GridPlus-gridplus/lattice

Conversation

@dasanra
Copy link
Collaborator

@dasanra dasanra commented Nov 4, 2020

We were having some difficulties merging the external PR because continuous changes from our side collided with external PR

This is the original PR for reference:
#1527

@dasanra dasanra requested a review from fernandomg November 4, 2020 17:30
@github-actions
Copy link

github-actions bot commented Nov 4, 2020

CLA Assistant Lite All Contributors have signed the CLA.

@dasanra dasanra self-assigned this Nov 4, 2020
@dasanra dasanra mentioned this pull request Nov 4, 2020
Closed
@github-actions
Copy link

github-actions bot commented Nov 4, 2020 •
edited
Loading

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 4 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

fernandomg
fernandomg reviewed Nov 4, 2020
View reviewed changes
Copy link
Contributor

@fernandomg fernandomg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we add it to the disabledWallets list on xDai, energy_web_chain and volta configs?

@ghost
Copy link

ghost commented Nov 4, 2020

Travis automatic deployment:
https://pr1569--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Nov 4, 2020

Travis automatic deployment:
https://pr1569--safereact.review.gnosisdev.com/rinkeby/app

@dasanra dasanra requested a review from fernandomg November 4, 2020 19:29
@ghost
Copy link

ghost commented Nov 4, 2020

Travis automatic deployment:
https://pr1569--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Nov 4, 2020

Travis automatic deployment:
https://pr1569--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Nov 5, 2020

Travis automatic deployment:
https://pr1569--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Nov 5, 2020

Travis automatic deployment:
https://pr1569--safereact.review.gnosisdev.com/volta/app

@dasanra dasanra merged commit 387ebe6 into development Nov 5, 2020
@dasanra dasanra deleted the GridPlus-gridplus/lattice branch November 5, 2020 15:02
@github-actions github-actions bot locked and limited conversation to collaborators Nov 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@fernandomg fernandomg fernandomg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dasanra dasanra

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dasanra @fernandomg @alex-miller-0