(Fix) Prevent ENS check when not supported#1570
Conversation
- created `BaseAddressBookInput` with the main functionality - created `AddressBookInput` and `ContractsAddressBookInput` wrappers
- disable ENS on `xDai`, `EWC` and `Volta`
|
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
Issue: In the Contract interaction form, whenever you write a random string of characters an error msj will show up (which is expected), but when I delete the string and I input a real contract address the Error message won't go away, even when the form loads the ABI from that contract address. |
@francovenica, |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
The issue was fixed I tried with some ENS names I have I checked that those are not read in the volta network and the error just reflects that those names are a string of characters, and not a ENS name. Tested in Contract Interactions, Address book entries, Settings user adding/replacement, Safe creation (for owners addresses), Safe Loading (for safes addresses) Looks good to me |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
This PR closes #1557, by:
AddressBookInputtoBaseAddressBookInputAddressBookInputandContractsAddressBookInput. Each one with its respective responsibilities.ENSchecks and error messages if it's not supported by the networkdisabledFeaturesentry forENSENSforEWC,Volta, andxDai.Notes:
AddressBookInputand the "form" state handling.AddressBookInputto prevent unnecessary re-renders and undesired updates.If changes around
AddressBookInputdoesn't justify the refactor, I can re-do this whole fix, and just add the ENS-related conditions in the previous code