Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

(Fix) - #1542 CopyBtn content in addressbook#1579

Merged
Agupane merged 4 commits intodevelopmentfrom
feature/#1542-safe-address-copy-to-clipboard-fix
Nov 10, 2020
Merged

(Fix) - #1542 CopyBtn content in addressbook#1579
Agupane merged 4 commits intodevelopmentfrom
feature/#1542-safe-address-copy-to-clipboard-fix

Conversation

@Agupane
Copy link
Contributor

@Agupane Agupane commented Nov 6, 2020

Closes #1542

@Agupane Agupane requested review from dasanra and fernandomg November 6, 2020 12:28
@Agupane Agupane self-assigned this Nov 6, 2020
@github-actions
Copy link

github-actions bot commented Nov 6, 2020

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Nov 6, 2020

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Nov 6, 2020

Travis automatic deployment:
https://pr1579--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Nov 6, 2020

Travis automatic deployment:
https://pr1579--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Nov 6, 2020

Travis automatic deployment:
https://pr1579--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Nov 6, 2020

Travis automatic deployment:
https://pr1579--safereact.review.gnosisdev.com/volta/app

@francovenica
Copy link
Contributor

What I think the ticket was reporting was the "Copy to clipboard" / "Etherscan" links in the owners editions in the settings.

The Copy to clipboard is working fine, but the Etherescan link is not:

Safe used to test: https://pr1579--safereact.review.gnosisdev.com/rinkeby/app/#/safes/0xf45A89409B04a1b7C9a8fe7b5665a7C06485B780/settings

image.png

@Agupane
Copy link
Contributor Author

Agupane commented Nov 9, 2020

It's done @francovenica

@ghost
Copy link

ghost commented Nov 9, 2020

Travis automatic deployment:
https://pr1579--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Nov 9, 2020

Travis automatic deployment:
https://pr1579--safereact.review.gnosisdev.com/volta/app

@francovenica
Copy link
Contributor

Issue Fixed.

Looks good to me

@ghost
Copy link

ghost commented Nov 10, 2020

Travis automatic deployment:
https://pr1579--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Nov 10, 2020

Travis automatic deployment:
https://pr1579--safereact.review.gnosisdev.com/rinkeby/app

@Agupane Agupane merged commit 2a01470 into development Nov 10, 2020
@Agupane Agupane deleted the feature/#1542-safe-address-copy-to-clipboard-fix branch November 10, 2020 14:51
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Any network: Safe address is used for owner address copy to clipboard/Open in .. on the Edit owner name pop-up

4 participants