(Fix) - #1154 Add more owners on safe creation by Agupane · Pull Request #1583 · 5afe/safe-react

Agupane · 2020-11-10T16:33:14Z

Closes #1154 by:

Fixing the uniqueAddress function that was checking if there are repeated values within an array
Also refactored the accepted type of that function from addresses: string[] | List<string> to addresses: string[]
Added some missing types and removed unused props on the SafeOwnersPage component
Also added types in OwnerForm component

Remove unused props

…tSelector

github-actions · 2020-11-10T16:33:33Z

CLA Assistant Lite All Contributors have signed the CLA.

github-actions · 2020-11-10T16:38:28Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	17	0
Ignored	2	N/A

Result: ✅ success
Annotations: 17 total

[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods

src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 47 - Missing return type on function.
src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 47 - Argument 'index' should be typed.
src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 47 - Argument 'notRemovedOwners' should be typed.
src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 47 - Argument 'values' should be typed.
src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 240 - Missing return type on function.
src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 240 - Argument 'controls' should be typed.
src/routes/open/components/SafeOwnersConfirmationsForm/index.tsx Line 240 - Object pattern argument should be typed.
src/routes/open/utils/safeDataExtractor.ts Line 6 - Missing return type on function.
src/routes/open/utils/safeDataExtractor.ts Line 6 - Argument 'values' should be typed.
src/routes/open/utils/safeDataExtractor.ts Line 14 - Missing return type on function.
src/routes/open/utils/safeDataExtractor.ts Line 14 - Argument 'values' should be typed.
src/routes/open/utils/safeDataExtractor.ts Line 22 - Argument 'names' should be typed.
src/routes/open/utils/safeDataExtractor.ts Line 22 - Argument 'addresses' should be typed.
src/routes/open/utils/safeDataExtractor.ts Line 28 - Missing return type on function.
src/routes/open/utils/safeDataExtractor.ts Line 28 - Argument 'values' should be typed.
src/routes/open/utils/safeDataExtractor.ts Line 30 - Missing return type on function.
src/routes/open/utils/safeDataExtractor.ts Line 30 - Argument 'values' should be typed.

^{Report generated by eslint-plus-action}

…to feature/#1154-add-more-owners-safe-creation # Conflicts: # src/components/forms/validator.ts

ghost · 2020-11-11T16:48:21Z

Travis automatic deployment:
https://pr1583--safereact.review.gnosisdev.com/rinkeby/app

ghost · 2020-11-11T16:48:39Z

Travis automatic deployment:
https://pr1583--safereact.review.gnosisdev.com/volta/app

…eation

ghost · 2020-11-11T17:34:09Z

Travis automatic deployment:
https://pr1583--safereact.review.gnosisdev.com/volta/app

ghost · 2020-11-11T17:35:21Z

Travis automatic deployment:
https://pr1583--safereact.review.gnosisdev.com/rinkeby/app

src/components/forms/validator.ts

src/logic/safe/store/selectors/index.ts

…fe-creation' into feature/#1154-add-more-owners-safe-creation

ghost · 2020-11-11T19:10:10Z

Travis automatic deployment:
https://pr1583--safereact.review.gnosisdev.com/rinkeby/app

ghost · 2020-11-11T19:10:28Z

Travis automatic deployment:
https://pr1583--safereact.review.gnosisdev.com/volta/app

src/logic/safe/store/selectors/index.ts

src/components/forms/validator.ts

src/routes/safe/components/AddressBook/CreateEditEntryModal/index.tsx

…/github.com/gnosis/safe-react into feature/#1154-add-more-owners-safe-creation

ghost · 2020-11-12T15:41:07Z

Travis automatic deployment:
https://pr1583--safereact.review.gnosisdev.com/rinkeby/app

ghost · 2020-11-12T15:42:46Z

Travis automatic deployment:
https://pr1583--safereact.review.gnosisdev.com/volta/app

…eation

ghost · 2020-11-12T16:28:52Z

Travis automatic deployment:
https://pr1583--safereact.review.gnosisdev.com/rinkeby/app

ghost · 2020-11-12T16:28:53Z

Travis automatic deployment:
https://pr1583--safereact.review.gnosisdev.com/volta/app

ghost · 2020-11-12T19:23:33Z

Travis automatic deployment:
https://pr1583--safereact.review.gnosisdev.com/rinkeby/app

ghost · 2020-11-12T19:30:26Z

Travis automatic deployment:
https://pr1583--safereact.review.gnosisdev.com/volta/app

…eation

ghost · 2020-11-12T19:49:31Z

Travis automatic deployment:
https://pr1583--safereact.review.gnosisdev.com/volta/app

ghost · 2020-11-12T19:49:32Z

Travis automatic deployment:
https://pr1583--safereact.review.gnosisdev.com/rinkeby/app

francovenica · 2020-11-13T13:50:52Z

https://pr1583--safereact.review.gnosisdev.com/rinkeby/app/#/open

Issue:
More than 10 owner still show the message "Address already introduced" in almost all of the new fields except for the first two and the last one
Also When having all those address filled, when one is deleted with the trashcan icon all the fields show the "Already introduced" error

francovenica

See Previous comment

ghost · 2020-11-13T14:59:22Z

Travis automatic deployment:
https://pr1583--safereact.review.gnosisdev.com/volta/app

ghost · 2020-11-13T15:00:39Z

Travis automatic deployment:
https://pr1583--safereact.review.gnosisdev.com/rinkeby/app

Agupane · 2020-11-13T15:03:49Z

Seems that the build was out of date, I ran the build again and seems working, please check it out @francovenica

francovenica · 2020-11-16T14:29:20Z

I was able to create a safe with 11 owners with no problem

https://pr1583--safereact.review.gnosisdev.com/rinkeby/app/#/safes/0x55632A8d8448AA617Bf24508a7CC5708b73C878d/settings

Note: I found other weird behaviors as you paste/duplicate addresses or delete rows, but those are issues that outside of what this ticket was about. I'll report those separately

…eation

ghost · 2020-11-16T15:13:35Z

Travis automatic deployment:
https://pr1583--safereact.review.gnosisdev.com/rinkeby/app

ghost · 2020-11-16T15:15:15Z

Travis automatic deployment:
https://pr1583--safereact.review.gnosisdev.com/volta/app

Agupane added 7 commits November 10, 2020 12:59

Add types in getAddressValidator

e1dfc93

Remove unused props

Absolute import

524561f

Adds safeOwnersAddressesSelector

7be4386

Fix uniqueAddress function

4e2aabe

Replaces getAddressesListFromAddressBook with addressBookAddressesLis…

95e8ebe

…tSelector

Remove comment

f7d2227

Types

c3bb51f

Agupane self-assigned this Nov 10, 2020

Agupane requested review from dasanra, fernandomg and francovenica November 10, 2020 16:33

Agupane added 2 commits November 11, 2020 10:23

Merge branch 'development' of https://github.com/gnosis/safe-react in…

9d0315f

…to feature/#1154-add-more-owners-safe-creation # Conflicts: # src/components/forms/validator.ts

Fix tests

bce7ca2

Agupane added 2 commits November 11, 2020 14:19

Merge branch 'development' into feature/#1154-add-more-owners-safe-cr…

570319a

…eation

Merge branch 'development' into feature/#1154-add-more-owners-safe-cr…

be5d085

…eation

fernandomg reviewed Nov 11, 2020

View reviewed changes

src/components/forms/validator.ts Outdated Show resolved Hide resolved

src/logic/safe/store/selectors/index.ts Outdated Show resolved Hide resolved

Agupane added 4 commits November 11, 2020 15:48

Improves safeOwnersAddressesSelector

ba98079

Remove memoize from uniqueAddress

66c8b61

Improves uniqueAddress validation

37b41e6

Merge remote-tracking branch 'origin/feature/#1154-add-more-owners-sa…

f2a67e6

…fe-creation' into feature/#1154-add-more-owners-safe-creation

mmv08 suggested changes Nov 11, 2020

View reviewed changes

src/logic/safe/store/selectors/index.ts Outdated Show resolved Hide resolved

mmv08 suggested changes Nov 11, 2020

View reviewed changes

src/components/forms/validator.ts Outdated Show resolved Hide resolved

src/routes/safe/components/AddressBook/CreateEditEntryModal/index.tsx Show resolved Hide resolved

Agupane added 3 commits November 12, 2020 12:19

Fix tests

72acfa0

Merge branch 'feature/#1154-add-more-owners-safe-creation' of https:/…

47857f6

…/github.com/gnosis/safe-react into feature/#1154-add-more-owners-safe-creation

Fix uniqueAddress

84f43b6

Merge branch 'development' into feature/#1154-add-more-owners-safe-cr…

0705b1f

…eation

Fix types extensions

5787b1a

dasanra approved these changes Nov 12, 2020

View reviewed changes

fernandomg approved these changes Nov 12, 2020

View reviewed changes

Merge branch 'development' into feature/#1154-add-more-owners-safe-cr…

0e955de

…eation

francovenica suggested changes Nov 13, 2020

View reviewed changes

Agupane requested a review from francovenica November 16, 2020 13:21

francovenica approved these changes Nov 16, 2020

View reviewed changes

Merge branch 'development' into feature/#1154-add-more-owners-safe-cr…

772548e

…eation

Agupane merged commit 3875195 into development Nov 17, 2020

Agupane deleted the feature/#1154-add-more-owners-safe-creation branch November 17, 2020 12:34

github-actions bot locked and limited conversation to collaborators Nov 17, 2020

Conversation

Agupane commented Nov 10, 2020

Uh oh!

github-actions bot commented Nov 10, 2020

Uh oh!

github-actions bot commented Nov 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ESLint Summary View Full Report

[warning] @typescript-eslint/explicit-module-boundary-types

Uh oh!

ghost commented Nov 11, 2020

Uh oh!

ghost commented Nov 11, 2020

Uh oh!

ghost commented Nov 11, 2020

Uh oh!

ghost commented Nov 11, 2020

Uh oh!

Uh oh!

Uh oh!

ghost commented Nov 11, 2020

Uh oh!

ghost commented Nov 11, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ghost commented Nov 12, 2020

Uh oh!

ghost commented Nov 12, 2020

Uh oh!

ghost commented Nov 12, 2020

Uh oh!

ghost commented Nov 12, 2020

Uh oh!

ghost commented Nov 12, 2020

Uh oh!

ghost commented Nov 12, 2020

Uh oh!

ghost commented Nov 12, 2020

Uh oh!

ghost commented Nov 12, 2020

Uh oh!

francovenica commented Nov 13, 2020

Uh oh!

francovenica left a comment

Choose a reason for hiding this comment

Uh oh!

ghost commented Nov 13, 2020

Uh oh!

ghost commented Nov 13, 2020

Uh oh!

Agupane commented Nov 13, 2020

Uh oh!

francovenica commented Nov 16, 2020

Uh oh!

ghost commented Nov 16, 2020

Uh oh!

ghost commented Nov 16, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

github-actions bot commented Nov 10, 2020 •

edited

Loading