(Fix) Remove the provider when the site is disconnected#1585
(Fix) Remove the provider when the site is disconnected#1585fernandomg merged 4 commits intodevelopmentfrom
Conversation
… account is not available
|
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
[warning] @typescript-eslint/explicit-module-boundary-types
Report generated by eslint-plus-action |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
@fernandomg Nice catch. I found one scenario where this still happen. It's not that critical because it's only once. If you |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
@dasanra, just created #1589, to keep track of this finding and a possible refactor of the connection management in the Safe. |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
Never thought about this one. Tried disconnecting from the MM prompt the connection to gnosis I had no problems reconnecting to the site after all this. Looks good to me |
When a user disconnected the Safe from the wallet, the Safe didn't remove the provider leading to the error:
Provided address "" is invalid, the capitalization checksum test failed, or it's an indirect IBAN address which can't be converted.This PR solves that issue by disconnecting the provider when there's no address provided by the connected wallet.