Feature #1593: Support promise-based api of Safe Apps SDK#1594
Feature #1593: Support promise-based api of Safe Apps SDK#1594mmv08 merged 52 commits intodevelopmentfrom
Conversation
…re/apps-sdk-promisified-api
|
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
…safe-react into feature/apps-sdk-promisified-api
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
…re/apps-sdk-promisified-api
ESLint Summary View Full Report
Report generated by eslint-plus-action |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
This reverts commit 1332940.
src/routes/safe/components/Apps/components/ConfirmTransactionModal.tsx
Outdated
Show resolved
Hide resolved
…safe-react into feature/apps-sdk-promisified-api
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
@francovenica to test this PR you can use the app provided in the description. This app uses the new features of apps SDK. You can also check that current Rinkeby apps still work as expected |
|
Travis automatic deployment: |
|
@francovenica you can use this deployed app to test the new functionalities of SDK https://ipfs.io/ipfs/QmfMq8NgxdDfai1qKv7bGbT8DegYX4mNzmpi9AkY1VJZBS |
|
I added the app using the URL Dani provided and it worked, but I had to refresh the page since adding it just show the loading icon forever (waited 20 mins till I refreshed manually to actually see the app) It seems the app create just test tx that do nothing of real effect, so I don't think the app itself requires any testing or validations, still I played with the amount of gas for the tx, and even putting a low number like "1000" and not getting the "Gas estimation is OK" sign the tx went through and it was mined just fine. Tx in rinkeby: https://rinkeby.etherscan.io/tx/0xe4f86cfaabacedc0096c492d6671b68341008c72e3e424dbafa4d7d7b8b03fa1 I tried in Rinkeby other apps: Compound, idle, sablier. With WC I tested just the connection with the "Wallet connect example" page It looks good for me |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
This PR:
An app for testing can be found here: https://github.com/gnosis/safe-test-app/tree/sdk/v2