(Feature) - EWC/Volta ENS support on web3 patch#1596
Conversation
|
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
fernandomg
left a comment
There was a problem hiding this comment.
code wise looks good.
I couldn't test volta ens, tho.
Tried to register a name but had no luck.
|
Travis automatic deployment: |
|
Travis automatic deployment: |
You can use |
|
I think that right now this isn't working because of web3 rollback version. Maybe we have to fix more web3 dependencies to apply this kind of fix. Can you please check it? |
Fix patch-package script in package.json
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
It's working now @dasanra @francovenica |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
I tested here: Checked that the ens names are working in volta, using "francovoltareal.ewc" in all the inputs that can read ens names: Create safe, load safe, send funds, contract interactions, address book, settings (owners add/replacement) Checked that for rinkeby the ENS names are still working as well Looks good to me |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
I'm not a real fan of this kind of patches, but as we are having troubles upgrading to web3 1.3.0 and there won't be any way to solve this in a short term until web3 1.4.0 we are going to take this approach |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
Closes #1540 by:
node_moduleslibrary and when you install the dependencies vianpm / yarnit will runpostinstallscript and apply the fixes to new installed thenode_modules