Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

(Feature) - EWC/Volta ENS support on web3 patch#1596

Merged
Agupane merged 12 commits intodevelopmentfrom
web3-ewc-support-patch
Nov 18, 2020
Merged

(Feature) - EWC/Volta ENS support on web3 patch#1596
Agupane merged 12 commits intodevelopmentfrom
web3-ewc-support-patch

Conversation

@Agupane
Copy link
Contributor

@Agupane Agupane commented Nov 12, 2020

Closes #1540 by:

  • Uses patch-package to add support for ewc/volta on the web3 config, the same changes that are here
  • This library is great, basically let you fix a node_modules library and when you install the dependencies via npm / yarn it will run postinstall script and apply the fixes to new installed the node_modules

@Agupane Agupane self-assigned this Nov 12, 2020
@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Nov 12, 2020

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 2 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Nov 12, 2020

Travis automatic deployment:
https://pr1596--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Nov 12, 2020

Travis automatic deployment:
https://pr1596--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Nov 12, 2020

Travis automatic deployment:
https://pr1596--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Nov 12, 2020

Travis automatic deployment:
https://pr1596--safereact.review.gnosisdev.com/volta/app

@fernandomg fernandomg changed the title (Feature) - EWC/Volta dns support on web3 patch (Feature) - EWC/Volta ENS support on web3 patch Nov 12, 2020
Copy link
Contributor

@fernandomg fernandomg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code wise looks good.

I couldn't test volta ens, tho.

Tried to register a name but had no luck.

@ghost
Copy link

ghost commented Nov 12, 2020

Travis automatic deployment:
https://pr1596--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Nov 12, 2020

Travis automatic deployment:
https://pr1596--safereact.review.gnosisdev.com/rinkeby/app

@Agupane
Copy link
Contributor Author

Agupane commented Nov 13, 2020

code wise looks good.

I couldn't test volta ens, tho.

Tried to register a name but had no luck.

You can use francovoltareal.ewc thanks to @francovenica :)

@dasanra
Copy link
Collaborator

dasanra commented Nov 13, 2020

I think that right now this isn't working because of web3 rollback version. Maybe we have to fix more web3 dependencies to apply this kind of fix. Can you please check it?

Fix patch-package script in package.json
@ghost
Copy link

ghost commented Nov 16, 2020

Travis automatic deployment:
https://pr1596--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Nov 16, 2020

Travis automatic deployment:
https://pr1596--safereact.review.gnosisdev.com/volta/app

@Agupane
Copy link
Contributor Author

Agupane commented Nov 16, 2020

It's working now @dasanra @francovenica

@ghost
Copy link

ghost commented Nov 16, 2020

Travis automatic deployment:
https://pr1596--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Nov 16, 2020

Travis automatic deployment:
https://pr1596--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Nov 17, 2020

Travis automatic deployment:
https://pr1596--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Nov 17, 2020

Travis automatic deployment:
https://pr1596--safereact.review.gnosisdev.com/rinkeby/app

@francovenica
Copy link
Contributor

I tested here:
https://pr1596--safereact.review.gnosisdev.com/volta/app/#/safes/0x538622a690A651D852277c07334dC3377E22cdeF/settings
https://pr1596--safereact.review.gnosisdev.com/rinkeby/app/#/safes/0x9913B9180C20C6b0F21B6480c84422F6ebc4B808/balances

Checked that the ens names are working in volta, using "francovoltareal.ewc" in all the inputs that can read ens names: Create safe, load safe, send funds, contract interactions, address book, settings (owners add/replacement)
Validations still work as well, ie: that ERNS name is a MM account, so the address is not valid for contract interactions or load as a safe

Checked that for rinkeby the ENS names are still working as well

Looks good to me

@ghost
Copy link

ghost commented Nov 18, 2020

Travis automatic deployment:
https://pr1596--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Nov 18, 2020

Travis automatic deployment:
https://pr1596--safereact.review.gnosisdev.com/volta/app

@dasanra
Copy link
Collaborator

dasanra commented Nov 18, 2020

I'm not a real fan of this kind of patches, but as we are having troubles upgrading to web3 1.3.0 and there won't be any way to solve this in a short term until web3 1.4.0 we are going to take this approach

@ghost
Copy link

ghost commented Nov 18, 2020

Travis automatic deployment:
https://pr1596--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Nov 18, 2020

Travis automatic deployment:
https://pr1596--safereact.review.gnosisdev.com/volta/app

@Agupane Agupane merged commit 3f6a8ee into development Nov 18, 2020
@Agupane Agupane deleted the web3-ewc-support-patch branch November 18, 2020 17:42
@github-actions github-actions bot locked and limited conversation to collaborators Nov 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[EWC/Volta]Can't use ENS name for the safe creation as an owner address

5 participants