(Fix) #1587 - Ens mislabeled as eth

[Agupane]

Closes #1587 by:

• Fixed default condition for incoming transactions: instead of using native symbol if fetching the symbol fails, first check if it's an ENS address, because the ENS contract address does not support symbol() method
• For outgoing transactions, there was a missing await on symbol() so I added it

[github-actions]

CLA Assistant Lite All Contributors have signed the CLA.

[github-actions]

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	0	0
Ignored	0	N/A

• Result: ✅ success
• Annotations: 0 total

---

^{Report generated by eslint-plus-action}

[ghost]

Travis automatic deployment:
https://pr1601--safereact.review.gnosisdev.com/volta/app

[ghost]

Travis automatic deployment:
https://pr1601--safereact.review.gnosisdev.com/rinkeby/app

[dasanra]

For which network is this ENS contract address?

[Agupane]

For both rinkeby and mainnet, not sure if for the deployed ENS contract for other networks have this issue with the symbol() method too. In any case would be better to have support for ewc/xDai in this method, do you have those addresses for adding them?

[dasanra]

For xDai I don't think we have it yet.
For EWC and Volta I think it should be the ETHBaseRegister ones:
https://energyweb.atlassian.net/wiki/spaces/EWF/pages/555745281/Using+ENS

[Agupane]

I'm thinking on adding the addresses on the config file what do you think?

[fernandomg]

Personally, I prefer the approach I took in https://github.com/gnosis/safe-react/blob/1587-ens-mislabeled-as-eth/src/logic/collectibles/utils/index.ts#L16-L19

It's so specific that populating the config files with that info will make them unnecessary complex in the future.

[Agupane]

That makes sense, will do that 👍

[Agupane]

I added ens addresses for both volta and ewc too 👍

[ghost]

Travis automatic deployment:
https://pr1601--safereact.review.gnosisdev.com/volta/app

[ghost]

Travis automatic deployment:
https://pr1601--safereact.review.gnosisdev.com/rinkeby/app

[francovenica]

I've checked this 2 safes that already have ENS tokens for incoming/outgoing tx's
They look fine

Safes:
https://pr1601--safereact.review.gnosisdev.com/rinkeby/app/#/safes/0x1230B3d59858296A31053C1b8562Ecf89A2f888b/transactions
https://pr1601--safereact.review.gnosisdev.com/rinkeby/app/#/safes/0xf2565317F3Ae8Ae9EA98E9Fe1e7FADC77F823cbD/transactions