Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

Layout refactor #1604

Merged
nicosampler merged 5 commits intodevelopmentfrom
issue-1590
Nov 17, 2020
Merged

Layout refactor #1604
nicosampler merged 5 commits intodevelopmentfrom
issue-1590

Conversation

@nicosampler
Copy link
Contributor

@nicosampler nicosampler commented Nov 13, 2020

Closes #1590 by replacing css-grid layout with flexfox.

The current css-grid layout was having some problems, we decided to migrate it to flexbox. Now It adapts better to the structure of the new layout.

@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Nov 13, 2020

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Nov 13, 2020

Travis automatic deployment:
https://pr1604--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Nov 13, 2020

Travis automatic deployment:
https://pr1604--safereact.review.gnosisdev.com/volta/app

@alongoni
Copy link
Contributor

alongoni commented Nov 13, 2020

I see two things a bit off.
1- New Transaction Button (Text in two lines)
2- Sidebar scroll at bottom.

image
I'll try to fix it.

@ghost
Copy link

ghost commented Nov 13, 2020

Travis automatic deployment:
https://pr1604--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Nov 13, 2020

Travis automatic deployment:
https://pr1604--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Nov 13, 2020

Travis automatic deployment:
https://pr1604--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Nov 13, 2020

Travis automatic deployment:
https://pr1604--safereact.review.gnosisdev.com/rinkeby/app

@alongoni
Copy link
Contributor

alongoni commented Nov 13, 2020

https://www.loom.com/share/181f8c6f0c1b46feba3a2f7f5acc34eb
I think it will not affect the scroll.

@fernandomg fernandomg mentioned this pull request Nov 16, 2020
@ghost
Copy link

ghost commented Nov 17, 2020

Travis automatic deployment:
https://pr1604--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Nov 17, 2020

Travis automatic deployment:
https://pr1604--safereact.review.gnosisdev.com/volta/app

@nicosampler nicosampler merged commit 996d339 into development Nov 17, 2020
@nicosampler nicosampler deleted the issue-1590 branch November 17, 2020 18:47
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Main Layout Problems

4 participants