Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

(Fix) - Adds operation call check on isTokenTransfer#1613

Merged
Agupane merged 7 commits intodevelopmentfrom
feature/1063-delegate-transfer-call-fix
Nov 18, 2020
Merged

(Fix) - Adds operation call check on isTokenTransfer#1613
Agupane merged 7 commits intodevelopmentfrom
feature/1063-delegate-transfer-call-fix

Conversation

@Agupane
Copy link
Contributor

@Agupane Agupane commented Nov 16, 2020

Closes #1063 by:

  • Checking the value of the operation for the transaction on the isTokenTransfer method

@Agupane Agupane self-assigned this Nov 16, 2020
@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Nov 16, 2020

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Nov 16, 2020

Travis automatic deployment:
https://pr1613--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Nov 16, 2020

Travis automatic deployment:
https://pr1613--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Nov 16, 2020

Travis automatic deployment:
https://pr1613--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Nov 16, 2020

Travis automatic deployment:
https://pr1613--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Nov 17, 2020

Travis automatic deployment:
https://pr1613--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Nov 17, 2020

Travis automatic deployment:
https://pr1613--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Nov 18, 2020

Travis automatic deployment:
https://pr1613--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Nov 18, 2020

Travis automatic deployment:
https://pr1613--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Nov 18, 2020

Travis automatic deployment:
https://pr1613--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Nov 18, 2020

Travis automatic deployment:
https://pr1613--safereact.review.gnosisdev.com/rinkeby/app

1 similar comment
@ghost
Copy link

ghost commented Nov 18, 2020

Travis automatic deployment:
https://pr1613--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Nov 18, 2020

Travis automatic deployment:
https://pr1613--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Nov 18, 2020

Travis automatic deployment:
https://pr1613--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Nov 18, 2020

Travis automatic deployment:
https://pr1613--safereact.review.gnosisdev.com/volta/app

@Agupane Agupane merged commit 8876469 into development Nov 18, 2020
@Agupane Agupane deleted the feature/1063-delegate-transfer-call-fix branch November 18, 2020 18:11
@github-actions github-actions bot locked and limited conversation to collaborators Nov 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Delegate call that calls transfer is marked as token transfer

4 participants