Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

Remove dappId from OnboardJS connection#1627

Merged
fernandomg merged 6 commits intodevelopmentfrom
fix/remove-dappId
Nov 26, 2020
Merged

Remove dappId from OnboardJS connection#1627
fernandomg merged 6 commits intodevelopmentfrom
fix/remove-dappId

Conversation

@matextrem
Copy link
Contributor

In order to make onboardJS works for EWC/Volta Networks, we need to remove dappId from onboardJS connection for preventing it from connecting to their Backend.

@matextrem matextrem added the Enhancement ✨ Minor Improvement / changes to existing functionality label Nov 18, 2020
@matextrem matextrem self-assigned this Nov 18, 2020
@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Nov 18, 2020

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 1 0
Ignored 1 N/A
  • Result: ✅ success

  • Annotations: 1 total


[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods


Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Nov 18, 2020

Travis automatic deployment:
https://pr1627--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Nov 18, 2020

Travis automatic deployment:
https://pr1627--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Nov 18, 2020

Travis automatic deployment:
https://pr1627--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Nov 18, 2020

Travis automatic deployment:
https://pr1627--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Nov 19, 2020

Travis automatic deployment:
https://pr1627--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Nov 19, 2020

Travis automatic deployment:
https://pr1627--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Nov 19, 2020

Travis automatic deployment:
https://pr1627--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Nov 19, 2020

Travis automatic deployment:
https://pr1627--safereact.review.gnosisdev.com/rinkeby/app

const wallets = getSupportedWallets()

export const onboard = Onboard({
dappId: BLOCKNATIVE_KEY,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to make it conditional?
at this moment, we know which network is the user using. So we can do something like this:
[EWC,Volta].includes(network) ? null : BLOCKNATIVE_KEY.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general BLOCKNATIVE_KEY is adding some console errors and we are not really using it.
They usually print a rate limit error and we are not using any functionality that needs a KEY.

I think we should remove it for all networks

@ghost
Copy link

ghost commented Nov 25, 2020

Travis automatic deployment:
https://pr1627--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Nov 25, 2020

Travis automatic deployment:
https://pr1627--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Nov 25, 2020

Travis automatic deployment:
https://pr1627--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Nov 25, 2020

Travis automatic deployment:
https://pr1627--safereact.review.gnosisdev.com/rinkeby/app

@fernandomg fernandomg merged commit e3a8b9f into development Nov 26, 2020
@fernandomg fernandomg deleted the fix/remove-dappId branch November 26, 2020 15:32
@github-actions github-actions bot locked and limited conversation to collaborators Nov 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Enhancement ✨ Minor Improvement / changes to existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants