Remove dappId from OnboardJS connection#1627
Conversation
|
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
[warning] @typescript-eslint/explicit-module-boundary-types
Report generated by eslint-plus-action |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
| const wallets = getSupportedWallets() | ||
|
|
||
| export const onboard = Onboard({ | ||
| dappId: BLOCKNATIVE_KEY, |
There was a problem hiding this comment.
is it possible to make it conditional?
at this moment, we know which network is the user using. So we can do something like this:
[EWC,Volta].includes(network) ? null : BLOCKNATIVE_KEY.
There was a problem hiding this comment.
In general BLOCKNATIVE_KEY is adding some console errors and we are not really using it.
They usually print a rate limit error and we are not using any functionality that needs a KEY.
I think we should remove it for all networks
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
In order to make onboardJS works for EWC/Volta Networks, we need to remove dappId from onboardJS connection for preventing it from connecting to their Backend.