Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

(Fix) - Uses addressbook names in the review remove owner#1631

Merged
dasanra merged 4 commits intodevelopmentfrom
fix/remove-owners-unknown-names
Nov 19, 2020
Merged

(Fix) - Uses addressbook names in the review remove owner#1631
dasanra merged 4 commits intodevelopmentfrom
fix/remove-owners-unknown-names

Conversation

@Agupane
Copy link
Contributor

@Agupane Agupane commented Nov 18, 2020 •
edited
Loading

Closes #1558 and #1606 by:

  • Using the addressbook entries for displaying the owners on the review delete owner component

@Agupane Agupane self-assigned this Nov 18, 2020
@github-actions
Copy link

github-actions bot commented Nov 18, 2020

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Nov 18, 2020 •
edited
Loading

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Nov 18, 2020

Travis automatic deployment:
https://pr1631--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Nov 18, 2020

Travis automatic deployment:
https://pr1631--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Nov 19, 2020

Travis automatic deployment:
https://pr1631--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Nov 19, 2020

Travis automatic deployment:
https://pr1631--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Nov 19, 2020

Travis automatic deployment:
https://pr1631--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Nov 19, 2020

Travis automatic deployment:
https://pr1631--safereact.review.gnosisdev.com/volta/app

@francovenica
Copy link
Contributor

francovenica commented Nov 19, 2020

Looks good to me

image.png

@ghost
Copy link

ghost commented Nov 19, 2020

Travis automatic deployment:
https://pr1631--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Nov 19, 2020

Travis automatic deployment:
https://pr1631--safereact.review.gnosisdev.com/rinkeby/app

@dasanra dasanra merged commit 592999d into development Nov 19, 2020
@dasanra dasanra deleted the fix/remove-owners-unknown-names branch November 19, 2020 15:40
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@fernandomg fernandomg Awaiting requested review from fernandomg

2 more reviewers

@francovenica francovenica francovenica approved these changes

@dasanra dasanra dasanra approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Agupane Agupane

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Replace owner modal is not showing the owners names properly

3 participants

@Agupane @francovenica @dasanra