Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

Bump dependencies without breaking changes#1632

Merged
dasanra merged 2 commits intodevelopmentfrom
upgrade-dependencies
Nov 20, 2020
Merged

Bump dependencies without breaking changes#1632
dasanra merged 2 commits intodevelopmentfrom
upgrade-dependencies

Conversation

@dasanra
Copy link
Collaborator

@dasanra dasanra commented Nov 19, 2020 •
edited
Loading

Bump dependencies to keep them up to date

@github-actions
Copy link

github-actions bot commented Nov 19, 2020

CLA Assistant Lite All Contributors have signed the CLA.

@dasanra dasanra self-assigned this Nov 19, 2020
@github-actions
Copy link

github-actions bot commented Nov 19, 2020 •
edited
Loading

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Nov 19, 2020

Travis automatic deployment:
https://pr1632--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Nov 19, 2020

Travis automatic deployment:
https://pr1632--safereact.review.gnosisdev.com/volta/app

fernandomg
fernandomg reviewed Nov 19, 2020
View reviewed changes
package.json
"@sentry/react": "^5.27.3",
"@sentry/tracing": "^5.27.3",
"@truffle/contract": "4.2.28",
"@sentry/react": "^5.27.0",
Copy link
Contributor

@fernandomg fernandomg Nov 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the decreased version?

Copy link
Contributor

@fernandomg fernandomg Nov 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm!... nevermind, the version will be correct after all.

Copy link
Collaborator Author

@dasanra dasanra Nov 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it was a test on handling dependencies in a more flexible way. This allows versions < 5.27.0 anyway and yarn resolve it like the latest 5.27.x

@ghost
Copy link

ghost commented Nov 19, 2020

Travis automatic deployment:
https://pr1632--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Nov 19, 2020

Travis automatic deployment:
https://pr1632--safereact.review.gnosisdev.com/rinkeby/app

@dasanra dasanra merged commit 9fdf4e2 into development Nov 20, 2020
@dasanra dasanra deleted the upgrade-dependencies branch November 20, 2020 08:26
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@nicosampler nicosampler Awaiting requested review from nicosampler

1 more reviewer

@fernandomg fernandomg fernandomg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dasanra dasanra

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dasanra @fernandomg