(Fix) Geth nodes gas estimation errors#1635
Conversation
Updates the extraction of data from the error message to include new GETH nodes version
|
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
1 similar comment
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
The issue is not popping anymore. I've tried to send a few tx. |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
src/logic/safe/transactions/gas.ts
Outdated
| // GETH Nodes (old version) | ||
| // In case that the gas is not enough we will receive an EMPTY data | ||
| // Otherwise we will receive the gas amount as hash data | ||
| // Otherwise we will receive the gas amount as hash data -> this is valid for old versions of GETH nodes |
There was a problem hiding this comment.
I think this will become legacy code with time, but instead of calling it "old versions" or "new GETH nodes" can we be more specific about the GETH version?
beautifully commented code, BTW
There was a problem hiding this comment.
Good idea, I updated the comment :)
|
Travis automatic deployment: |
|
Travis automatic deployment: |
Closes #1633 by:
tryblock while the new implementation will run on thecatch