Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

(Fix) Geth nodes gas estimation errors#1635

Merged
dasanra merged 8 commits intodevelopmentfrom
fix/geth-nodes-errors
Nov 20, 2020
Merged

(Fix) Geth nodes gas estimation errors#1635
dasanra merged 8 commits intodevelopmentfrom
fix/geth-nodes-errors

Conversation

@Agupane
Copy link
Contributor

@Agupane Agupane commented Nov 19, 2020

Closes #1633 by:

  • Updating how we parse the data response from GETH nodes (on the new version they return the data as error within the exception), so we need to parse the exception to get the data of the tx
  • I leave the old implementation for geth nodes in case that some services are still out of date, both implementations can run at the same time on our code, the old implementation will go on the try block while the new implementation will run on the catch

Updates the extraction of data from the error message to include new GETH nodes version
@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Nov 19, 2020

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 1 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Nov 19, 2020

Travis automatic deployment:
https://pr1635--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Nov 19, 2020

Travis automatic deployment:
https://pr1635--safereact.review.gnosisdev.com/rinkeby/app

1 similar comment
@ghost
Copy link

ghost commented Nov 19, 2020

Travis automatic deployment:
https://pr1635--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Nov 19, 2020

Travis automatic deployment:
https://pr1635--safereact.review.gnosisdev.com/volta/app

@francovenica
Copy link
Contributor

The issue is not popping anymore. I've tried to send a few tx.
It loos good to me

@ghost
Copy link

ghost commented Nov 20, 2020

Travis automatic deployment:
https://pr1635--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Nov 20, 2020

Travis automatic deployment:
https://pr1635--safereact.review.gnosisdev.com/rinkeby/app

@Agupane Agupane requested a review from dasanra November 20, 2020 12:50
// GETH Nodes (old version)
// In case that the gas is not enough we will receive an EMPTY data
// Otherwise we will receive the gas amount as hash data
// Otherwise we will receive the gas amount as hash data -> this is valid for old versions of GETH nodes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will become legacy code with time, but instead of calling it "old versions" or "new GETH nodes" can we be more specific about the GETH version?

beautifully commented code, BTW

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, I updated the comment :)

@ghost
Copy link

ghost commented Nov 20, 2020

Travis automatic deployment:
https://pr1635--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Nov 20, 2020

Travis automatic deployment:
https://pr1635--safereact.review.gnosisdev.com/volta/app

@dasanra dasanra merged commit 6ed1e2e into development Nov 20, 2020
@dasanra dasanra deleted the fix/geth-nodes-errors branch November 20, 2020 16:56
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error calculating tx gas estimation

4 participants