Support Circles Safes in frontend on xDai #1636
Conversation
|
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
[warning] @typescript-eslint/explicit-module-boundary-types
Report generated by eslint-plus-action |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
| context?: unknown | ||
| methods: Array<string | {method: string, type?: string, args: MethodsArgsType }> | ||
| } | ||
| methods: Array<string | { method: string; type?: string; args: MethodsArgsType }> |
There was a problem hiding this comment.
Why shouldn't we use the simple coma here , ?
There was a problem hiding this comment.
it was prettier who changed it
src/logic/contracts/safeContracts.ts
Outdated
| export const DEFAULT_FALLBACK_HANDLER_ADDRESS = '0xd5D82B6aDDc9027B22dCA772Aa68D5d74cdBdF44' | ||
| export const SAFE_MASTER_COPY_ADDRESS_V10 = '0xb6029EA3B2c51D09a50B53CA8012FeEB05bDa35A' | ||
|
|
||
| const web3 = getWeb3() |
There was a problem hiding this comment.
I'm pretty sure that doing this may lead to potential errors. I think it was ok by calling getWeb3 from within every function.
If the provider changes during runtime, this pointer won't get updated.
Also, by memoizing you're doing the same thing, you're getting an instance of a Contract instantiated with a particular provider. If it changes during runtime, you'll try to send a transaction, and it will fail.
Please, correct me if I'm wrong.
Also, if you're just using a contract instance only to call a method, it's better to use the web3ReadOnly exported ref.
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
| const getMasterCopyInfo = async () => { | ||
| const masterCopies = await fetchMasterCopies() | ||
| const masterCopyAddress = await getMasterCopyAddressFromProxyAddress(safeAddress) | ||
| const masterCopy = masterCopies?.find((mc) => mc.address === masterCopyAddress) |
There was a problem hiding this comment.
nitpicking, but can we use the sameAddress function instead of ===?
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
I created an account in circles.garden and loaded a safe with the normal workflow The safe in the Release branch: I had a small amount of xDai and the 50 CRC tokens already in my wallet Something to note is that I received 0.5 CRC at some point, but is not the same CRC token I originally had. It seems even that there are a ton of different CRC tokens for this type of safe |
5 participants
Closes #1578 #1636.
Sorry but this PR contains mixed changes.