Conversation
- changed how the module pair is organized, now it's more natural (prev, module) tuple
|
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
I gave it a try in a safe where I have 3 modules and I was having issues to remove it in other PR's.
|
| const safeAddress = useSelector(safeParamAddressFromStateSelector) | ||
| const dispatch = useDispatch() | ||
|
|
||
| const explorerInfo = getExplorerInfo(selectedModule[0]) |
There was a problem hiding this comment.
can we rename selectedModule to selectedPairModule?
also, could it be possible to assign const prevModule = selectedModule[0]? I think it will help to understand what selectedModule[0] is.
There was a problem hiding this comment.
the assignment to a variable was already done, but I'm going with the selectedModulePair variable name
nicosampler
left a comment
nicosampler
left a comment
There was a problem hiding this comment.
@fernandomg I left comments, please take a look at them.
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
5 participants
This PR closes #1367, by: