Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

(Fix) - Shows a timeout message on app timeout#1654

Merged
Agupane merged 7 commits intodevelopmentfrom
feature/app-fail-ipfs
Dec 3, 2020
Merged

(Fix) - Shows a timeout message on app timeout#1654
Agupane merged 7 commits intodevelopmentfrom
feature/app-fail-ipfs

Conversation

@Agupane
Copy link
Contributor

@Agupane Agupane commented Nov 25, 2020 •
edited
Loading

Closes #1303 by:

  • Adding a timeout message once the timeout is reached without loading the app.

Gif

@Agupane Agupane self-assigned this Nov 25, 2020
@github-actions
Copy link

github-actions bot commented Nov 25, 2020

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Nov 25, 2020 •
edited
Loading

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Nov 25, 2020

Travis automatic deployment:
https://pr1654--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Nov 25, 2020

Travis automatic deployment:
https://pr1654--safereact.review.gnosisdev.com/rinkeby/app

mmv08
mmv08 reviewed Nov 25, 2020
View reviewed changes
@ghost
Copy link

ghost commented Nov 26, 2020

Travis automatic deployment:
https://pr1654--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Nov 26, 2020

Travis automatic deployment:
https://pr1654--safereact.review.gnosisdev.com/rinkeby/app

@Agupane
Merge branch 'development' of https://github.com/gnosis/safe-react in…
66ea074 
…to feature/app-fail-ipfs

# Conflicts:
#	src/routes/safe/components/Apps/components/AppFrame.tsx
@Agupane
Improves loading text
1e5dfb2
@Agupane
Improves clear timeout
00f6de6
@ghost
Copy link

ghost commented Nov 30, 2020

Travis automatic deployment:
https://pr1654--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Nov 30, 2020

Travis automatic deployment:
https://pr1654--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Nov 30, 2020

Travis automatic deployment:
https://pr1654--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Nov 30, 2020

Travis automatic deployment:
https://pr1654--safereact.review.gnosisdev.com/volta/app

@pablofullana pablofullana requested a review from mmv08 December 1, 2020 14:43
@ghost
Copy link

ghost commented Dec 2, 2020

Travis automatic deployment:
https://pr1654--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Dec 2, 2020

Travis automatic deployment:
https://pr1654--safereact.review.gnosisdev.com/rinkeby/app

@francovenica
Copy link
Contributor

francovenica commented Dec 2, 2020

The message is fine. Still I want to see it the day ipfs is actually failing like the day the ticket #1303 was created.

The wording is ok, but probably it should be validated by @tschubotz
image.png

@tschubotz
Copy link
Contributor

tschubotz commented Dec 3, 2020

The wording is ok, but probably it should be validated by @tschubotz

For an error message I think it's okay.

@Agupane Agupane merged commit c0a8d24 into development Dec 3, 2020
@Agupane Agupane deleted the feature/app-fail-ipfs branch December 3, 2020 11:56
@github-actions github-actions bot locked and limited conversation to collaborators Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mmv08 mmv08 Awaiting requested review from mmv08

4 more reviewers

@fernandomg fernandomg fernandomg approved these changes

@nicosampler nicosampler nicosampler approved these changes

@francovenica francovenica francovenica approved these changes

@dasanra dasanra dasanra approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Agupane Agupane

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Apps fail to load if IPFS takes too long to respond

7 participants

@Agupane @francovenica @tschubotz @fernandomg @nicosampler @mmv08 @dasanra