Welcome Screen by alongoni · Pull Request #1655 · 5afe/safe-react

alongoni · 2020-11-25T19:54:31Z

Related to #1648

github-actions · 2020-11-25T19:54:48Z

CLA Assistant Lite All Contributors have signed the CLA.

github-actions · 2020-11-25T19:59:39Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	2	0
Ignored	0	N/A

Result: ✅ success
Annotations: 2 total

[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods

src/components/ConnectButton/index.tsx Line 66 - Missing return type on function.
src/components/ConnectButton/index.tsx Line 75 - Argument 'props' should be typed.

^{Report generated by eslint-plus-action}

ghost · 2020-11-25T20:10:25Z

Travis automatic deployment:
https://pr1655--safereact.review.gnosisdev.com/volta/app

ghost · 2020-11-25T20:10:54Z

Travis automatic deployment:
https://pr1655--safereact.review.gnosisdev.com/rinkeby/app

lukasschor · 2020-11-25T20:21:19Z

src/routes/welcome/components/Layout.tsx

-      collectively. It is an improvement of the Gnosis MultiSig, which is used by more than 3000 teams
-      <br /> and stores over $1B USD worth of digital assets. Gnosis Safe Multisig features a modular
-      <br /> design, formally verified smart contracts and vastly improved user experience.{' '}
+      Gnosis Safe Multisig is the most trusted platform to manage <br /> digital assets on Ethereum. Here is how to get


Can we change this to:

Gnosis Safe Multisig is the most trusted platform to manage digital assets. <br /> Here is how to get started:{' '}

As Safe isn't only available on Ethereum anymore.

ghost · 2020-11-25T21:18:04Z

Travis automatic deployment:
https://pr1655--safereact.review.gnosisdev.com/rinkeby/app

ghost · 2020-11-25T21:18:26Z

Travis automatic deployment:
https://pr1655--safereact.review.gnosisdev.com/volta/app

nicosampler · 2020-12-09T20:12:31Z

src/routes/safe/container/index.tsx

  const matchSafeWithAddress = useRouteMatch<{ safeAddress: string }>({ path: `${SAFELIST_ADDRESS}/:safeAddress` })
  const safeAppsEnabled = Boolean(featuresEnabled?.includes(FEATURES.SAFE_APPS))

-  if (!safeAddress) {


This code is obsolete, there is no way to reach this page without a safeAddress.

ghost · 2020-12-09T22:23:41Z

Travis automatic deployment:
https://pr1655--safereact.review.gnosisdev.com/rinkeby/app

ghost · 2020-12-09T22:41:22Z

Travis automatic deployment:
https://pr1655--safereact.review.gnosisdev.com/volta/app

ghost · 2020-12-10T12:27:00Z

Travis automatic deployment:
https://pr1655--safereact.review.gnosisdev.com/volta/app

francovenica · 2020-12-10T18:35:56Z

If this ticket is only for the design part then I'll move the following comment to another ticket

Regarding design and how it fits is all ok, looks good

Regarding the Connect button:
When you are connected to a wallet like MM and try to connect with another like a ledger/trezor/WC/Portis.... what happens is that it only disconnects you and you have to click again the connect button so you can actually connect to the page with a new wallet
https://www.loom.com/share/9d0c301a1e62453780d61cd7d6cc077a

Note: This only happens with wallets that are not MM, this means, if you are connected with a Trezor for example and you change to MM it will disconnect you from trezor connect you with MM in a single action

So, the proposal would be:
1 - While connected with any wallet, when I hit connect and choose another type of wallet, the system should disconnect me from the current wallet and automatically start the process to connect with the one I chose
2 - Make the "Connect" button in this design to change to "Disconnect" if I'm connected with a wallet already, the same way we did with the buttons connect/disconnect in the top right corner

nicosampler · 2020-12-10T20:22:06Z

@francovenica how is it working in development?

francovenica · 2020-12-10T22:09:29Z

@nicosampler The button "Connect" changes to "Disconnect" in the top right corner. And in the page itself the button "Connect" is completely replaced by "Load" and "Create" buttons.

lukasschor · 2020-12-10T22:20:00Z

I think the first step should be grayed out and the "Connect" button should not be clickable when a wallet is connected.

The same way step two is non-interactive initially

@posthnikova What do you think?

nicosampler · 2020-12-11T10:07:14Z

@lukasschor I think it's useful if you want to change the wallet.

ghost · 2020-12-11T10:22:32Z

Travis automatic deployment:
https://pr1655--safereact.review.gnosisdev.com/rinkeby/app

ghost · 2020-12-11T10:37:30Z

Travis automatic deployment:
https://pr1655--safereact.review.gnosisdev.com/volta/app

posthnikova · 2020-12-11T10:40:09Z

I think the first step should be grayed out and the "Connect" button should not be clickable when a wallet is
connected.

@lukasschor Maybe only the button. This step is 'done' and it should differ visually from 'to do' steps. You might still wish to access the help article.

I think it's useful if you want to change the wallet.

Wallet can be changed by disconnecting in the wallet dropdown.

ghost · 2020-12-11T14:42:42Z

Travis automatic deployment:
https://pr1655--safereact.review.gnosisdev.com/rinkeby/app

nicosampler · 2020-12-11T14:44:54Z

@lukasschor @francovenica welcome is disabled now when a wallet is connected.

lukasschor · 2020-12-11T14:50:25Z

👀

ghost · 2020-12-11T14:57:26Z

Travis automatic deployment:
https://pr1655--safereact.review.gnosisdev.com/volta/app

francovenica · 2020-12-11T19:33:22Z

The connect button being greyed out is working fine.

Still we got to fix what Lukas reported with the "New Transactions" button

ghost · 2020-12-11T20:48:30Z

Travis automatic deployment:
https://pr1655--safereact.review.gnosisdev.com/rinkeby/app

ghost · 2020-12-11T21:03:31Z

Travis automatic deployment:
https://pr1655--safereact.review.gnosisdev.com/volta/app

francovenica · 2020-12-11T21:24:47Z

The button was fixed.

Looks good to me

alongoni added 4 commits November 5, 2020 15:41

add cards and styles on texts

fdc0645

Merge branch 'development' into welcome-new-design

e074cd7

add styles and conten

1643280

align card content

3ce774f

alongoni requested a review from nicosampler November 25, 2020 19:54

lukasschor reviewed Nov 25, 2020

View reviewed changes

fix text about Safe Multisig

a44ebde

alongoni and others added 10 commits November 30, 2020 15:29

add new components from SRC

accf4b4

update SRC

acc936d

changes to welcome page

a1415e1

fix margins

574d451

update SRC

917013b

fix icon size

abb08bb

update SRC hash

fe410eb

Dot: replacer number by check when wallet is connected

5db5979

fix card width

159be82

add url to help to connect wallet.

919070c

alongoni requested a review from fernandomg December 3, 2020 17:30

remove underline on button as a link (Load Safe).

0f13bd2

nicosampler reviewed Dec 9, 2020

View reviewed changes

Merge branch 'development' into welcome-new-design

7cbefd0

Fix buttnos

686d65f

dasanra approved these changes Dec 10, 2020

View reviewed changes

dasanra marked this pull request as ready for review December 10, 2020 12:15

dasanra requested a review from francovenica December 10, 2020 15:32

fernandomg approved these changes Dec 10, 2020

View reviewed changes

Merge branch 'development' into welcome-new-design

78783a3

disable connect wallet button when theres is a connected wallet

f5d66f9

alongoni and others added 2 commits December 11, 2020 15:11

fix padding in New Transaction button

879c217

Merge branch 'development' into welcome-new-design

efd3e9e

Merge branch 'development' into welcome-new-design

2e14d31

francovenica approved these changes Dec 11, 2020

View reviewed changes

dasanra merged commit 1bb3ebc into development Dec 11, 2020

dasanra deleted the welcome-new-design branch December 11, 2020 21:47

github-actions bot locked and limited conversation to collaborators Dec 11, 2020

Conversation

alongoni commented Nov 25, 2020

Uh oh!

github-actions bot commented Nov 25, 2020

Uh oh!

github-actions bot commented Nov 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ESLint Summary View Full Report

[warning] @typescript-eslint/explicit-module-boundary-types

Uh oh!

ghost commented Nov 25, 2020

Uh oh!

ghost commented Nov 25, 2020

Uh oh!

lukasschor Nov 25, 2020

Choose a reason for hiding this comment

Uh oh!

ghost commented Nov 25, 2020

Uh oh!

ghost commented Nov 25, 2020

Uh oh!

nicosampler Dec 9, 2020

Choose a reason for hiding this comment

Uh oh!

ghost commented Dec 9, 2020

Uh oh!

ghost commented Dec 9, 2020

Uh oh!

ghost commented Dec 10, 2020

Uh oh!

francovenica commented Dec 10, 2020

Uh oh!

nicosampler commented Dec 10, 2020

Uh oh!

francovenica commented Dec 10, 2020

Uh oh!

lukasschor commented Dec 10, 2020

Uh oh!

nicosampler commented Dec 11, 2020

Uh oh!

ghost commented Dec 11, 2020

Uh oh!

ghost commented Dec 11, 2020

Uh oh!

posthnikova commented Dec 11, 2020

Uh oh!

ghost commented Dec 11, 2020

Uh oh!

nicosampler commented Dec 11, 2020

Uh oh!

lukasschor commented Dec 11, 2020

Uh oh!

ghost commented Dec 11, 2020

Uh oh!

francovenica commented Dec 11, 2020

Uh oh!

ghost commented Dec 11, 2020

Uh oh!

ghost commented Dec 11, 2020

Uh oh!

francovenica commented Dec 11, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

github-actions bot commented Nov 25, 2020 •

edited

Loading