(Feature) - #1656 Tx is sent to backend even if not signed

[Agupane]

Closes #1656 by:

• Checks if the error comes from metamask missing signature before trying to execute the tx
• Also fixs the black notification when the user rejects the signature

[github-actions]

CLA Assistant Lite All Contributors have signed the CLA.

[github-actions]

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	1	0
Ignored	0	N/A

• Result: ✅ success

• Annotations: 1 total

  ---

[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods

• src/logic/safe/transactions/offchainSigner/index.ts Line 22 - Argument 'txArgs' should be typed.

---

^{Report generated by eslint-plus-action}

[ghost]

Travis automatic deployment:
https://pr1672--safereact.review.gnosisdev.com/rinkeby/app

[ghost]

Travis automatic deployment:
https://pr1672--safereact.review.gnosisdev.com/volta/app

[fernandomg]

@Agupane, this seems to be the solution for a safe with a threshold of 1.

I think you should check processTransaction as well. If I reject the execution of a tx, it will error without even a notification

[fernandomg]

If I reject the attempt to sign an off-chain tx, this condition is true as the tryOffchainSigning throws an error without code

[Agupane]

Thanks for the feedback, was very useful, found also more bugs with notifications on proccessTransaction that I fixed as well

[ghost]

Travis automatic deployment:
https://pr1672--safereact.review.gnosisdev.com/volta/app

[ghost]

Travis automatic deployment:
https://pr1672--safereact.review.gnosisdev.com/rinkeby/app

[fernandomg]

Nice! Unpopular opinion: I love being able to see the error notification 😛

A thing I stumbled upon was one of those console errors that appear from time to time

Following the stack trace, it was triggered here

Can you give it a look and try to fix it in this PR? It will help with #1650

[Agupane]

Nice! Unpopular opinion: I love being able to see the error notification 😛

A thing I stumbled upon was one of those console errors that appear from time to time

Following the stack trace, it was triggered here

Can you give it a look and try to fix it in this PR? It will help with #1650

Did you found a way to reproduce this?

[ghost]

Travis automatic deployment:
https://pr1672--safereact.review.gnosisdev.com/rinkeby/app

[ghost]

Travis automatic deployment:
https://pr1672--safereact.review.gnosisdev.com/volta/app

[fernandomg]

Did you found a way to reproduce this?

@Agupane, I couldn't find a way to reproduce it. But I'd try to avoid assuming that prev will always exist.

I'd go with something around prev?.set('dismissed', true)

[ghost]

Travis automatic deployment:
https://pr1672--safereact.review.gnosisdev.com/rinkeby/app

[ghost]

Travis automatic deployment:
https://pr1672--safereact.review.gnosisdev.com/volta/app

[ghost]

Travis automatic deployment:
https://pr1672--safereact.review.gnosisdev.com/volta/app

[ghost]

Travis automatic deployment:
https://pr1672--safereact.review.gnosisdev.com/rinkeby/app

[francovenica]

Created a Tx and cancelled the MM prompt when it showed up

Looks good to me. Snapshots for comparison:

In this PR:

How it looked before: