Remove safe address tracking for GA by nicosampler · Pull Request #1683 · 5afe/safe-react

nicosampler · 2020-12-01T16:32:36Z

Closes #1642.

This PR removes the safe address from GA tracking by replacing any address with SAFE_ADDRESS placeholder.

github-actions · 2020-12-01T16:55:22Z

CLA Assistant Lite All Contributors have signed the CLA.

github-actions · 2020-12-01T17:00:36Z

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type	Occurrences	Fixable
Errors	0	0
Warnings	3	0
Ignored	0	N/A

Result: ✅ success
Annotations: 3 total

[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods

src/routes/open/container/Open.tsx Line 57 - Missing return type on function.
src/routes/open/container/Open.tsx Line 57 - Argument 'values' should be typed.
src/routes/open/container/Open.tsx Line 57 - Argument 'userAccount' should be typed.

^{Report generated by eslint-plus-action}

dasanra · 2020-12-02T08:16:16Z

src/utils/googleAnalytics.ts

-    GoogleAnalytics.set({
+    ReactGA.initialize(trackingID, {
+      gaOptions: {
+        siteSpeedSampleRate: 100,


Should we remove this parameter? I think this is only for testing purposes

ghost · 2020-12-02T09:02:24Z

Travis automatic deployment:
https://pr1683--safereact.review.gnosisdev.com/volta/app

…1642

ghost · 2020-12-02T11:51:24Z

Travis automatic deployment:
https://pr1683--safereact.review.gnosisdev.com/volta/app

ghost · 2020-12-02T12:12:41Z

Travis automatic deployment:
https://pr1683--safereact.review.gnosisdev.com/volta/app

ghost · 2020-12-02T12:41:31Z

Travis automatic deployment:
https://pr1683--safereact.review.gnosisdev.com/volta/app

ghost · 2020-12-02T13:09:30Z

Travis automatic deployment:
https://pr1683--safereact.review.gnosisdev.com/volta/app

ghost · 2020-12-02T18:09:47Z

Travis automatic deployment:
https://pr1683--safereact.review.gnosisdev.com/volta/app

francovenica · 2020-12-02T19:21:21Z

@tschubotz Talked with Nico and I'll need access to Google analytics to check this one. Can you give me access?

tschubotz · 2020-12-03T09:17:50Z

@francovenica just added you to all web projects on https://analytics.google.com

francovenica · 2020-12-03T17:10:40Z

It seems that the Travis system is having issues and it is not creating an env for rinkeby. I tried in volta, but I've checked in the network tab and it seems GA is not working there (or is not being called, I don't know if it is even configured for volta)

So to test this Nico and I checked in his local env with him configurating the env for Rinkeby and having the GA also configured for Rinkeby

He visited several pages that have the .../safes/SAFE_ADDRESS/ structure and instead of login the actual address in GA, it would log /safes/SAFE_ADDRESS/balances for example

This is a snapshot of GA of today. Nico visited several pages and we checked that those are registered as safes/SAFE_ADDRESS instead of the real actual address.
Note that there still some addresses in GA, those eventually will disappear as the fix is implemented in low test env and prod

https://analytics.google.com/analytics/web/#/report/content-overview/a180094170w216025621p206479581/_u.date00=20201203&_u.date01=20201203/

ghost · 2020-12-03T18:08:51Z

Travis automatic deployment:
https://pr1683--safereact.review.gnosisdev.com/volta/app

matextrem · 2020-12-03T22:20:15Z

src/routes/index.tsx

+      // prevent logging safeAddress
+      let safePage = `${SAFELIST_ADDRESS}/SAFE_ADDRESS`
+      if (matchSafeWithAction.params?.safeAction) {
+        safePage += `/${matchSafeWithAction.params?.safeAction}`


could we use template literals instead?

ghost · 2020-12-04T18:17:18Z

Travis automatic deployment:
https://pr1683--safereact.review.gnosisdev.com/rinkeby/app

ghost · 2020-12-04T18:20:27Z

Travis automatic deployment:
https://pr1683--safereact.review.gnosisdev.com/volta/app

ghost · 2020-12-05T15:49:50Z

Travis automatic deployment:
https://pr1683--safereact.review.gnosisdev.com/rinkeby/app

ghost · 2020-12-05T15:50:29Z

Travis automatic deployment:
https://pr1683--safereact.review.gnosisdev.com/volta/app

ghost · 2020-12-09T13:13:07Z

Travis automatic deployment:
https://pr1683--safereact.review.gnosisdev.com/volta/app

ghost · 2020-12-09T18:35:34Z

Travis automatic deployment:
https://pr1683--safereact.review.gnosisdev.com/rinkeby/app

ghost · 2020-12-09T18:52:25Z

Travis automatic deployment:
https://pr1683--safereact.review.gnosisdev.com/volta/app

ghost · 2020-12-09T19:22:30Z

Travis automatic deployment:
https://pr1683--safereact.review.gnosisdev.com/rinkeby/app

ghost · 2020-12-09T19:39:00Z

Travis automatic deployment:
https://pr1683--safereact.review.gnosisdev.com/volta/app

nicosampler added 2 commits December 1, 2020 10:07

reactGA bump

ace373a

remove address from GA

64cbc0a

nicosampler requested review from Agupane, dasanra, fernandomg and matextrem December 1, 2020 16:32

dasanra reviewed Dec 2, 2020

View reviewed changes

remove unneeded option

fd545b3

nicosampler requested a review from dasanra December 2, 2020 11:38

nicosampler and others added 2 commits December 2, 2020 08:38

Merge branch 'development' into issue-1642

9b9381d

Merge branch 'issue-1642' of github.com:gnosis/safe-react into issue-…

365a827

…1642

TEST: add network concurrency to fix CI

5646c18

remove network concurrency

bc7a508

Agupane approved these changes Dec 2, 2020

View reviewed changes

dasanra approved these changes Dec 2, 2020

View reviewed changes

Merge branch 'development' into issue-1642

34d20d2

matextrem reviewed Dec 3, 2020

View reviewed changes

matextrem approved these changes Dec 3, 2020

View reviewed changes

Daniel Sanchez added 2 commits December 4, 2020 17:58

Disable travis cache

805f69d

Merge branch 'development' into issue-1642

b9517c0

Merge branch 'development' into issue-1642

9200a4c

Merge branch 'development' into issue-1642

20e2e75

Daniel Sanchez added 2 commits December 9, 2020 17:53

Set travis to use latest linux build image

3716056

Update to use python3 dependencies

c0f8b8d

Merge branch 'development' into issue-1642

ccb1bc3

dasanra merged commit 2fe1fb2 into development Dec 9, 2020

dasanra deleted the issue-1642 branch December 9, 2020 19:45

github-actions bot locked and limited conversation to collaborators Dec 9, 2020

Conversation

nicosampler commented Dec 1, 2020

Uh oh!

github-actions bot commented Dec 1, 2020

Uh oh!

github-actions bot commented Dec 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

ESLint Summary View Full Report

[warning] @typescript-eslint/explicit-module-boundary-types

Uh oh!

dasanra Dec 2, 2020

Choose a reason for hiding this comment

Uh oh!

nicosampler Dec 2, 2020

Choose a reason for hiding this comment

Uh oh!

ghost commented Dec 2, 2020

Uh oh!

ghost commented Dec 2, 2020

Uh oh!

ghost commented Dec 2, 2020

Uh oh!

ghost commented Dec 2, 2020

Uh oh!

ghost commented Dec 2, 2020

Uh oh!

ghost commented Dec 2, 2020

Uh oh!

francovenica commented Dec 2, 2020

Uh oh!

tschubotz commented Dec 3, 2020

Uh oh!

francovenica commented Dec 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Dec 3, 2020

Uh oh!

matextrem Dec 3, 2020

Choose a reason for hiding this comment

Uh oh!

ghost commented Dec 4, 2020

Uh oh!

ghost commented Dec 4, 2020

Uh oh!

ghost commented Dec 5, 2020

Uh oh!

ghost commented Dec 5, 2020

Uh oh!

ghost commented Dec 9, 2020

Uh oh!

ghost commented Dec 9, 2020

Uh oh!

ghost commented Dec 9, 2020

Uh oh!

ghost commented Dec 9, 2020

Uh oh!

ghost commented Dec 9, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

github-actions bot commented Dec 1, 2020 •

edited

Loading

francovenica commented Dec 3, 2020 •

edited

Loading