Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

Handle console erros and warnings#1709

Merged
dasanra merged 6 commits intodevelopmentfrom
issue-1650
Dec 11, 2020
Merged

Handle console erros and warnings#1709
dasanra merged 6 commits intodevelopmentfrom
issue-1650

Conversation

@nicosampler
Copy link
Contributor

closes #1650

  • I have fixed some MM warnings.
  • fixed an error in the safe-creation process.
  • did a fix workaround for this warning
    image

For the other errors reported in the ticket, I could not reproduce them.

@github-actions
Copy link

github-actions bot commented Dec 9, 2020

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Dec 10, 2020

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 4 0
Ignored 3 N/A
  • Result: ✅ success

  • Annotations: 4 total


[warning] @typescript-eslint/explicit-module-boundary-types

Require explicit return and argument types on exported functions' and classes' public class methods


Report generated by eslint-plus-action

@@ -1,8 +1,11 @@
import Web3 from 'web3'
export {}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤯

@ghost
Copy link

ghost commented Dec 10, 2020

Travis automatic deployment:
https://pr1709--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Dec 10, 2020

Travis automatic deployment:
https://pr1709--safereact.review.gnosisdev.com/volta/app

@ghost
Copy link

ghost commented Dec 11, 2020

Travis automatic deployment:
https://pr1709--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Dec 11, 2020

Travis automatic deployment:
https://pr1709--safereact.review.gnosisdev.com/volta/app

@dasanra dasanra merged commit c9a06ec into development Dec 11, 2020
@dasanra dasanra deleted the issue-1650 branch December 11, 2020 18:38
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review console errors

3 participants