Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

Bug: Use link tag instead of javascript navigation in apps list#1770

Merged
mmv08 merged 5 commits intodevelopmentfrom
bug/apps-list-a-tag
Jan 13, 2021
Merged

Bug: Use link tag instead of javascript navigation in apps list#1770
mmv08 merged 5 commits intodevelopmentfrom
bug/apps-list-a-tag

Conversation

@mmv08
Copy link
Contributor

@mmv08 mmv08 commented Jan 13, 2021

This PR:

  • Makes use of <a> tag in apps list because attaching a listener to div is not a good accessibility practice, also it's hard to distinguish between apps when you're developing locally
  • Add declaration for styled components theme

@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Jan 13, 2021

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Jan 13, 2021

Travis automatic deployment:
https://pr1770--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Jan 13, 2021

Travis automatic deployment:
https://pr1770--safereact.review.gnosisdev.com/volta/app

height: 232px !important;
box-sizing: border-box;
cursor: pointer;
color: ${fontColor};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one more question, why can't we use something linke so: ${({ theme }) => theme.colors.background}?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

forgot it 😄 a good catch
I also added a declaration for SC theme

@ghost
Copy link

ghost commented Jan 13, 2021

Travis automatic deployment:
https://pr1770--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Jan 13, 2021

Travis automatic deployment:
https://pr1770--safereact.review.gnosisdev.com/volta/app

@mmv08 mmv08 merged commit 1a50b59 into development Jan 13, 2021
@mmv08 mmv08 deleted the bug/apps-list-a-tag branch January 13, 2021 13:28
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants