Bug: Use link tag instead of javascript navigation in apps list#1770
Bug: Use link tag instead of javascript navigation in apps list#1770mmv08 merged 5 commits intodevelopmentfrom
Conversation
|
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
|
Travis automatic deployment: |
|
Travis automatic deployment: |
| height: 232px !important; | ||
| box-sizing: border-box; | ||
| cursor: pointer; | ||
| color: ${fontColor}; |
There was a problem hiding this comment.
one more question, why can't we use something linke so: ${({ theme }) => theme.colors.background}?
There was a problem hiding this comment.
forgot it 😄 a good catch
I also added a declaration for SC theme
|
Travis automatic deployment: |
|
Travis automatic deployment: |
This PR:
<a>tag in apps list because attaching a listener to div is not a good accessibility practice, also it's hard to distinguish between apps when you're developing locally