Skip to content
This repository was archived by the owner on Nov 10, 2023. It is now read-only.

(Fix) - #1783 Trezor gas estimation fail#1788

Merged
dasanra merged 6 commits intorelease/v2.18.0from
fix/1783-trezor-gas-estimation-fail
Jan 18, 2021
Merged

(Fix) - #1783 Trezor gas estimation fail#1788
dasanra merged 6 commits intorelease/v2.18.0from
fix/1783-trezor-gas-estimation-fail

Conversation

@Agupane
Copy link
Contributor

@Agupane Agupane commented Jan 18, 2021

Closes #1783

Description

  • The getDataFromNodeErrorMessage function which is a function that parses the error response of non geth nodes in order to extract the estimationData wasn't supporting the way how trezor sends that error message. We were expecting an error message like this:
msg execution reverted:
{
      "originalError": {
      "code": 3,
      "message": "execution reverted:",
      "data": "0x08c379a0000000000000000000000000000000000000000000000000000000000000002000000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000006457"}
}

But trezor just sends:

0x08c379a0000000000000000000000000000000000000000000000000000000000000002000000000000000000000000000000000000000000000000000000000000000200000000000000000000000000000000000000000000000000000000000006457

This prs adds the logic for that case

@Agupane Agupane self-assigned this Jan 18, 2021
@Agupane Agupane changed the base branch from development to release/v2.18.0 January 18, 2021 14:31
@github-actions
Copy link

CLA Assistant Lite All Contributors have signed the CLA.

@github-actions
Copy link

github-actions bot commented Jan 18, 2021

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 1 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@ghost
Copy link

ghost commented Jan 18, 2021

Travis automatic deployment:
https://pr1788--safereact.review.gnosisdev.com/rinkeby/app

@ghost
Copy link

ghost commented Jan 18, 2021

Travis automatic deployment:
https://pr1788--safereact.review.gnosisdev.com/volta/app

@dasanra dasanra merged commit ce43a97 into release/v2.18.0 Jan 18, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2021
@dasanra dasanra deleted the fix/1783-trezor-gas-estimation-fail branch January 20, 2021 08:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trezor signature always show the warning that the tx will fail

2 participants