This repository was archived by the owner on Nov 10, 2023. It is now read-only.
(Fix) - #1783 Trezor gas estimation fail#1788
Merged
dasanra merged 6 commits intorelease/v2.18.0from Jan 18, 2021
Merged
Conversation
…ssage for supporting trezor response
|
CLA Assistant Lite All Contributors have signed the CLA. |
ESLint Summary View Full Report
Report generated by eslint-plus-action |
dasanra
approved these changes
Jan 18, 2021
…com/gnosis/safe-react into fix/1783-trezor-gas-estimation-fail
|
Travis automatic deployment: |
|
Travis automatic deployment: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1783
Description
getDataFromNodeErrorMessagefunction which is a function that parses the error response of non geth nodes in order to extract theestimationDatawasn't supporting the way how trezor sends that error message. We were expecting an error message like this:But trezor just sends:
This prs adds the logic for that case